Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support PhantAuth authentication #5850

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Conversation

szkiba
Copy link
Contributor

@szkiba szkiba commented Jul 26, 2019

PhantAuth was designed to simplify testing of applications using OpenID Connect authentication by making use of randomly generated users.

By using PhantAuth, you can test applications built on Parse Server with an unlimited number of test users. It could bring the developers of applications using Parse Server considerable added value.

To learn more, please visit: https://www.phantauth.net

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just a few changes

* PhantAuth was designed to simplify testing for applications using OpenID Connect
* authentication by making use of random generated users.
*
* To learn more, please go to: https://wwww.phantauth.net
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.phantauth.net, you have an extra w

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanx, fixed

});
}

// Returns a promise that fulfills iff this app id is valid.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*if

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanx, fixed

src/Adapters/Auth/phantauth.js Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #5850 into master will increase coverage by 0.03%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5850      +/-   ##
=========================================
+ Coverage   93.66%   93.7%   +0.03%     
=========================================
  Files         150     151       +1     
  Lines       10616   10626      +10     
=========================================
+ Hits         9944    9957      +13     
+ Misses        672     669       -3
Impacted Files Coverage Δ
src/Adapters/Auth/index.js 92.98% <100%> (+0.12%) ⬆️
src/Adapters/Auth/phantauth.js 88.88% <88.88%> (ø)
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.56% <0%> (+0.71%) ⬆️
src/Adapters/Auth/httpsRequest.js 100% <0%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd637ff...e7a877d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #5850 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5850      +/-   ##
==========================================
+ Coverage   93.66%   93.71%   +0.05%     
==========================================
  Files         150      151       +1     
  Lines       10616    10621       +5     
==========================================
+ Hits         9944     9954      +10     
+ Misses        672      667       -5
Impacted Files Coverage Δ
src/Adapters/Auth/index.js 92.98% <100%> (+0.12%) ⬆️
src/Adapters/Auth/phantauth.js 100% <100%> (ø)
src/LiveQuery/ParseWebSocketServer.js 94.73% <0%> (-0.51%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.97% <0%> (+0.07%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.56% <0%> (+0.71%) ⬆️
src/Adapters/Auth/httpsRequest.js 100% <0%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd637ff...1a838af. Read the comment docs.

@dplewis dplewis merged commit dfe0ff7 into parse-community:master Jul 29, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* support PhantAuth authentication

* fix spelling issues

* Add test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants