Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rest option: excludeKeys #5737

Merged
merged 2 commits into from
Jul 10, 2019

Conversation

RaschidJFR
Copy link
Contributor

@RaschidJFR RaschidJFR commented Jun 27, 2019

Added support for rest parameter excludeKeys in queries (similar to keys) in order to exclude the desired fields from retrieved objects.

Fixes #4948

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Just a few changes

spec/ParseQuery.spec.js Outdated Show resolved Hide resolved
src/RestQuery.js Show resolved Hide resolved
@RaschidJFR
Copy link
Contributor Author

Sure. I will aply the changes as soon as I get a chance.

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #5737 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5737      +/-   ##
==========================================
- Coverage   93.67%   93.64%   -0.04%     
==========================================
  Files         145      145              
  Lines       10188    10229      +41     
==========================================
+ Hits         9544     9579      +35     
- Misses        644      650       +6
Impacted Files Coverage Δ
src/RestQuery.js 95.63% <100%> (+0.15%) ⬆️
src/Routers/ClassesRouter.js 96.7% <100%> (+0.07%) ⬆️
src/GraphQL/loaders/usersQueries.js 89.28% <0%> (-3.58%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 91.72% <0%> (-0.73%) ⬇️
src/RestWrite.js 93.32% <0%> (-0.18%) ⬇️
src/Adapters/Auth/apple-signin.js
src/Adapters/Auth/apple.js 100% <0%> (ø)
src/Adapters/Auth/index.js 92.85% <0%> (+0.12%) ⬆️
src/GraphQL/loaders/parseClassTypes.js 84.15% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87592b6...31debc1. Read the comment docs.

@dplewis dplewis requested a review from acinader July 10, 2019 17:54
@dplewis
Copy link
Member

dplewis commented Jul 10, 2019

@RaschidJFR Thanks for the PR. I cleaned it up and add more tests to get this into the next release.

@acinader how does this look?

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhmazing

@dplewis dplewis merged commit 9816285 into parse-community:master Jul 10, 2019
@RaschidJFR RaschidJFR deleted the unselect-keys branch July 10, 2019 21:48
@RaschidJFR
Copy link
Contributor Author

Great, I'm glad it was useful. I'm paying clsoe attention to the process and tests so the next PR need less changes.
So I guess the next step is to incorporate it into the SDK, am I right?

@dplewis
Copy link
Member

dplewis commented Jul 10, 2019

Yeah the SDK's and the Docs are next. Adding new features like this takes a lot of time.

We can wait until the server release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Deselect Keys
3 participants