Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Cache Improvement 2 #5616

Merged
merged 7 commits into from
May 30, 2019
Merged

Schema Cache Improvement 2 #5616

merged 7 commits into from
May 30, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 26, 2019

Reduce the number of create/update/destroy object calls to cache.

After the class and fields have been validated and cached, no need to reload the schema from cache if already validated.

Create/Update/Destroy just does lookup from the cache.

I’m more than happy to answer any questions or would like feedback.

@codecov
Copy link

codecov bot commented May 26, 2019

Codecov Report

Merging #5616 into master will decrease coverage by <.01%.
The diff coverage is 91.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5616      +/-   ##
==========================================
- Coverage   94.13%   94.13%   -0.01%     
==========================================
  Files         129      129              
  Lines        9231     9235       +4     
==========================================
+ Hits         8690     8693       +3     
- Misses        541      542       +1
Impacted Files Coverage Δ
src/rest.js 98.86% <100%> (+0.01%) ⬆️
src/Controllers/SchemaController.js 96.88% <100%> (-0.23%) ⬇️
src/RestWrite.js 93.64% <100%> (+0.02%) ⬆️
src/Controllers/DatabaseController.js 95% <91.22%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b804245...afb0fcb. Read the comment docs.

spec/RedisCacheAdapter.spec.js Show resolved Hide resolved
spec/RedisCacheAdapter.spec.js Show resolved Hide resolved
src/rest.js Show resolved Hide resolved
src/rest.js Show resolved Hide resolved
@dplewis dplewis requested a review from acinader May 29, 2019 18:04
@dplewis dplewis merged commit cc6d474 into master May 30, 2019
@dplewis dplewis deleted the cache-saveAll branch May 30, 2019 16:14
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* schema hasClass improvement

* create object improvement

* destroy object

* update object

* hasClass test rewrite

* more tests

* improve signing up users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants