FilesAdapter for Azure Blob Storage

[aneeshd16]

This is a FilesAdapter for uploading, accessing and deleting files on Azure Blob Storage.
It is very similar to how the S3 adapter works.

Use the AzureBlobStorageAdapter as the filesAdapter when initializing parse-server.

options.filesAdapter = new AzureBlobStorageAdapter(
        '<connection-string>',
        '<container-name>',
        {}  
);

or with more options:

options.filesAdapter = new AzureBlobStorageAdapter(
        '<storage-account-name>',
        '<container-name>',
        {
            storageAccessKey: <storage-access-key>,
            host: <host>,
            directAccess: <true|false>
        }   
);

IMO, this addition is needed since parse-server already supports direct deployment to Azure.

This is my first PR at a major repo, I am open to feedback and suggestions! Thanks!

[flovilmart]

would be more consistent with other adapters to only have one parameter options

[flovilmart]

@aneeshd16 that looks great, unit tests would be nice too, even if they fail as you don't want to provide your keys there :)

we were also talking with @drew-gross about the future of those adapters and we both are in favour to remove them from the core repository, and reference them through dependencies.

Moving to a dependency would also help for the testing as you'll be able to put encrypted keys in travis for the unit tests to run and check for failures.

I'm working on a PR (#549) that will enable a simpler and more flexible adapter architecture.

[aneeshd16]

Thanks for the review! Yes, I'll add unit tests soon. Looking forward to the new design.

[facebook-github-bot]

@aneeshd16 updated the pull request.

[flovilmart]

please rebase and add the according tests into https://github.com/ParsePlatform/parse-server/blob/master/spec/FilesController.spec.js

[aneeshd16]

Okay will do!

[flovilmart]

Thx!

[felixrieseberg]

Oh man, we just saw the pull request - @aneeshd16, this is awesome! We at Microsoft made felixrieseberg/parse-server-azure-storage, but it'd certainly be great to have some tests (and for this to be more integrated with the Parse-Server development).

[aneeshd16]

This is great! Tests are on the way. < 24hrs

[facebook-github-bot]

@aneeshd16 updated the pull request.

[codecov-io]

Current coverage is 90.09%

Merging #545 into master will decrease coverage by -1.55% as of 63e534d

@@            master    #545   diff @@
======================================
  Files           73      74     +1
  Stmts         4438    4482    +44
  Branches       889     901    +12
  Methods          0       0       
======================================
- Hit           4067    4038    -29
  Partial         10      10       
- Missed         361     434    +73

Review entire Coverage Diff as of 63e534d

Powered by Codecov. Updated on successful CI builds.

[aneeshd16]

@flovilmart Added the mount parameter here https://github.com/ParsePlatform/parse-server/blob/master/spec/FilesControllerTestFactory.js#L8
All tests pass!

[facebook-github-bot]

@aneeshd16 updated the pull request.

[facebook-github-bot]

@aneeshd16 updated the pull request.

[facebook-github-bot]

@aneeshd16 updated the pull request.

[onosol]

Is this getting merged into a new version soon? With this merged, I'm ready to go with a full Azure deployment :) Just curious what the status is.....thanks

[aneeshd16]

Yep, me too. Just tell me what needs to be done so that this can be merged!

[facebook-github-bot]

@aneeshd16 updated the pull request.

[felixrieseberg]

@onsol: In the meantime, we at Microsoft made an adapter you can use today.

var ParseServer         = require('parse-server').ParseServer;
var AzureStorageAdapter = require('parse-server-azure').FilesAdapter;

var account = 'YOUR_AZURE_STORAGE_ACCOUNT_NAME';
var container = 'YOUR_AZURE_STORAGE_CONTAINER_NAME';
var options = {
    accessKey: 'YOUR_ACCESS_KEY',
    directAccess: false // If set to true, files will be served by Azure Blob Storage directly
}

var api = new ParseServer({
  appId: process.env.APP_ID || 'myAppId',
  serverURL: process.env.SERVER_URL || 'http://localhost:1337'
  (...)
  filesAdapter: new AzureStorageAdapter(account, container, options);
});

[onosol]

@felixrieseberg
Will check it out...thanks!

[gfosco]

Like #971 I'd really like to see this become its own module on npm, instead of being included in the core server. It's easier to test and maintain that way. For example: https://www.npmjs.com/package/parse-server-sendgrid-adapter

[felixrieseberg]

...and @aneeshd16, we at Microsoft would love contributions over at https://www.npmjs.com/package/parse-server-azure ❤️!

[flovilmart]

Closing as we pimped the adapter tests and moved all adapters to external packaged