Ensure the ACL is always part of the payload when using select #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovilmart
force-pushed
the
fix/js-sdk-issue-571
branch
from
3272e2d
to
eec8b99
Compare
acinader
previously approved these changes
Aug 15, 2018
Codecov Report
@@ Coverage Diff @@
## master #4967 +/- ##
==========================================
+ Coverage 94.26% 94.27% +<.01%
==========================================
Files 120 120
Lines 8743 8751 +8
==========================================
+ Hits 8242 8250 +8
Misses 501 501
Continue to review full report at Codecov.
|
acinader
previously approved these changes
Aug 15, 2018
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
…-community#4967) * Ensure the ACL is always part of the payload when using select * Update changelog * fix for PG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue raised here
ACLas a key to select, until now, using select would prevent fetching the ACL in any caseThe second point is more debatable, as it marks a departure from the original implementation, where only objectId, createdAt, updatedAt would be always returned. Now also ACL's are returned.
I can very well revert it so ACL's are only returned when asked with a select.