Support incrementing push badge value by more than 1 #4889
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4889 +/- ##
==========================================
+ Coverage 92.85% 92.88% +0.02%
==========================================
Files 119 119
Lines 8821 8828 +7
==========================================
+ Hits 8191 8200 +9
+ Misses 630 628 -2
Continue to review full report at Codecov.
|
…than string (IncrementBy3)
src/Controllers/PushController.js
Outdated
| parseInt(badge.substring(incrementby.length), 10) > 0) { | ||
| restUpdate = { badge: { __op: 'Increment', amount: parseInt(badge.substring(incrementby.length), 10) } } | ||
| } else if (typeof badge == 'object' && 'increment' in badge && Number(badge.increment)) { | ||
| restUpdate = { badge: { __op: 'Increment', amount: badge.increment } } |
There was a problem hiding this comment.
If you're talking about using it but only supporting the "increment" case, I'm happy to make the changes.
If you mean more broadly supporting all the same operations, I don't understand all the ramifications well enough myself to be confident in implementing that (I'm fairly new to the code base and likely don't have the time right now to get up to speed on all those different flows)
There was a problem hiding this comment.
Yeah, for now that would be just for the increment. Sorry for the back and forths. I believe if we use the same JSON based objects as the rest of the API we’ll be happier on the long term
rdbayer
changed the title
|
Awesome! Thanks for the PR and sticking with the change requests :) |
* Support 'IncrementByN' badge value for higher push badge increments
* Fix test
* Rely on object for badge incrementation (i.e. {increment: 3}) rather than string (IncrementBy3)
* For badge incrementation, utilize format similar to other operation notation
* Support 'IncrementByN' badge value for higher push badge increments
* Fix test
* Rely on object for badge incrementation (i.e. {increment: 3}) rather than string (IncrementBy3)
* For badge incrementation, utilize format similar to other operation notation
…#4889) * Support 'IncrementByN' badge value for higher push badge increments * Fix test * Rely on object for badge incrementation (i.e. {increment: 3}) rather than string (IncrementBy3) * For badge incrementation, utilize format similar to other operation notation
No description provided.