Fix server crash on invalid LiveQuery socket event #4533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending an invalid event through the LiveQuery client socket crashes the server process.
Reproduce on the client:
Server logs:
This PR fixes it by making the
op
property required in the general LiveQuery RequestSchema.I added a test case and removed the
tv4.validate
mock to make the error visible, and updated the existing tests to pass when using the original module.