Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes postgres flaky test #3822

Merged
merged 2 commits into from
May 16, 2017
Merged

Fixes postgres flaky test #3822

merged 2 commits into from
May 16, 2017

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented May 16, 2017 •
edited
Loading

Closes #3754

@flovilmart flovilmart changed the title Changes expected error code Fixes postgres flaky test May 16, 2017
@codecov
Copy link

codecov bot commented May 16, 2017 •
edited
Loading

Codecov Report

Merging #3822 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3822      +/-   ##
==========================================
- Coverage   90.15%   90.13%   -0.03%     
==========================================
  Files         114      114              
  Lines        7529     7531       +2     
==========================================
  Hits         6788     6788              
- Misses        741      743       +2
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.46% <100%> (+0.01%) ⬆️
src/Adapters/Storage/Postgres/PostgresClient.js 85.71% <100%> (ø) ⬆️
src/RestWrite.js 92.85% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab04641...32810db. Read the comment docs.

@flovilmart flovilmart requested a review from acinader May 16, 2017 03:43
acinader
acinader approved these changes May 16, 2017
View reviewed changes
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@acinader acinader merged commit 9dbb89a into master May 16, 2017
@flovilmart flovilmart deleted the pg-flaky-test branch May 16, 2017 18:01
@dplewis dplewis mentioned this pull request Mar 23, 2018
Closed
@parseplatformorg parseplatformorg mentioned this pull request Feb 11, 2024
Closed
@skmezanul skmezanul mentioned this pull request Feb 11, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Feb 12, 2024
Closed
@kiarza2543 kiarza2543 mentioned this pull request Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acinader acinader acinader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flovilmart @acinader