Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch unhandled rejection with installation-handling #3795

Merged

Conversation

kahoona77
Copy link
Contributor

Hi,

as mentioned in #3758 I now found the time to fix the unhandled rejections when dealing with installations. I added catch-blocks to the delete-statements in RestWrite.js . The error is ignored when it is "ObjectNotFound". Otherwise it will be rethrown.
We already use this in our production environment without problems. And log log now no longer has "unhandled rejection" warnings.

Best regards,
Benjamin

@codecov
Copy link

codecov bot commented May 9, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@8d67776). Click here to learn what that means.
The diff coverage is 27.27%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3795   +/-   ##
========================================
  Coverage          ?   90.1%           
========================================
  Files             ?     114           
  Lines             ?    7500           
  Branches          ?       0           
========================================
  Hits              ?    6758           
  Misses            ?     742           
  Partials          ?       0
Impacted Files Coverage Δ
src/RestWrite.js 93.21% <27.27%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d67776...a876e11. Read the comment docs.

@flovilmart flovilmart merged commit 64e6f40 into parse-community:master May 9, 2017
@flovilmart
Copy link
Contributor

Fixes #3758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants