add test that adds ACL in beforeSave hook #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerBrock
force-pushed
the
before-save-acl
branch
from
e0d8013
to
0758275
Compare
|
Can you define the cloud code for the test inside the test and the remove it with _removeHook? See |
|
@TylerBrock updated the pull request. |
|
Sure, hygienic, I like that. |
TylerBrock
force-pushed
the
before-save-acl
branch
from
0758275
to
3c7a538
Compare
|
@TylerBrock updated the pull request. |
TylerBrock
force-pushed
the
before-save-acl
branch
from
3c7a538
to
1987877
Compare
|
@TylerBrock updated the pull request. |
TylerBrock
force-pushed
the
before-save-acl
branch
from
1987877
to
f4a633e
Compare
TylerBrock
changed the title
|
@TylerBrock updated the pull request. |
TylerBrock
force-pushed
the
before-save-acl
branch
from
f4a633e
to
e3fd4de
Compare
|
Figured it out, might be nice to have the test anyway, feel free to merge or close. |
|
@TylerBrock updated the pull request. |
|
The test look good to me |
Current coverage is 92.17%@@ master #1772 diff @@
==========================================
Files 87 87
Lines 6206 6206
Methods 1069 1069
Messages 0 0
Branches 1292 1292
==========================================
Hits 5720 5720
Misses 486 486
Partials 0 0
|
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of odd, I wrote this test to figure out why parse-server isn't saving my ACL's when i set them in beforeSave triggers but the test can't even pass the
get(id)phase when an acl is set on object in beforeSave. Not sure what is going on here.