🚧 ⚡ debugging NAN compile failures #1122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imlucas updated the pull request. |
|
Thanks man! |
|
@imlucas updated the pull request. |
| } | ||
|
|
||
| // Start MongoDB before running the test suite and stop it afterwards. | ||
| before(require('mongodb-runner/mocha/before')); |
There was a problem hiding this comment.
we use jasmine, should be beforeAll and afterAll
|
@imlucas updated the pull request. |
|
@imlucas updated the pull request. |
|
@imlucas updated the pull request. |
|
I think this is out of date. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed travis is complaining: https://travis-ci.org/ParsePlatform/parse-server/jobs/117440718#L196
Please don't merge just yet. Opening PR to create a travis job I can use for debugging. Once this is resolved, I'll rebase this down into more logical commits.