Skip to content

fix: Installation update is written to the installation named by the request's installation ID instead of the addressed object (GHSA-8j8q-73xx-w3m4) - #10792

Merged
mtrezza merged 1 commit into
parse-community:alphafrom
mtrezza:fix/GHSA-8j8q-73xx-w3m4-9
Oct 15, 2026
Merged

mtrezza merged 1 commit into
parse-community:alphafrom
mtrezza:fix/GHSA-8j8q-73xx-w3m4-9

Conversation

@mtrezza

@mtrezza mtrezza commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Issue

Installation update is written to the installation named by the request's installation ID instead of the addressed object (GHSA-8j8q-73xx-w3m4)

Tasks

  • Add tests

@parse-github-assistant

Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 59ba321c-5518-4340-bb62-4e08dced8988
📥 Commits

Reviewing files that changed from the base of the PR and between ee88ce3 and 91e41b0.

📒 Files selected for processing: 2
  • spec/vulnerabilities.spec.js
  • src/RestWrite.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Installation-ID fallback for installation requests now applies only to creates. Regression tests cover updates addressed by object ID, access denial, trigger behavior, create resolution, and SDK saves.

Changes: Installation Update Resolution

Layer / File(s) Summary
Installation ID resolution and regression coverage
src/RestWrite.js, spec/vulnerabilities.spec.js
Updates without an explicit installationId no longer inherit the caller’s installation ID for lookup. Tests verify that object-ID updates target the addressed installation, inaccessible targets return OBJECT_NOT_FOUND without changing either installation or running beforeSave, and creates retain header-based resolution.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~12 minutes

Merge Risk: ⚪ Minimal · up to 91e41

The installation-ID fallback remains available for creates without changing the supported update paths. No issue identified here prevents merging after normal checks.

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

Failed Failed checks: 1 error

Check name Status Explanation Resolution
Description check Error The pull request has no description. It does not provide the required Issue, Approach, or Tasks information from the repository template. Add a pull request description that includes the Issue and Approach sections. Complete the applicable Tasks, including the regression tests and security check, and remove or mark inapplicable tasks.
Passed Passed checks: 6 passed
Check name Status Explanation
Title check Passed The title uses the required fix: prefix, starts the subject with an uppercase letter, and identifies the security issue addressed by the changes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Security Check Passed PASS. The pull request changes only _Installation identity resolution in src/RestWrite.js. auth.installationId is now used only when this.query is absent, so create deduplication still resolve…
Engage In Review Feedback Passed No review feedback comments or actionable findings were supplied. Therefore, there was no feedback to ignore, resolve, implement, or discuss.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-merge checks failed. Please resolve the failing checks before merging.

@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.02%. Comparing base (e895091) to head (91e41b0).
⚠️ Report is 1 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha   #10792      +/-   ##
==========================================
- Coverage   94.03%   94.02%   -0.01%     
==========================================
  Files         193      193              
  Lines       17239    17239              
  Branches      259      259              
==========================================
- Hits        16210    16209       -1     
- Misses       1007     1008       +1     
  Partials       22       22              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza changed the title fix: GHSA-8j8q-73xx-w3m4 fix: Installation update is written to the installation named by the request's installation ID instead of the addressed object (GHSA-8j8q-73xx-w3m4) Oct 15, 2026
@mtrezza
mtrezza merged commit 256a253 into parse-community:alpha Oct 15, 2026
24 of 25 checks passed
@mtrezza
mtrezza deleted the fix/GHSA-8j8q-73xx-w3m4-9 branch October 15, 2026 22:48
parseplatformorg pushed a commit that referenced this pull request Oct 15, 2026
## [9.10.5-alpha.10](9.10.5-alpha.9...9.10.5-alpha.10) (2026-10-15)

### Bug Fixes

* Installation update is written to the installation named by the request's installation ID instead of the addressed object ([GHSA-8j8q-73xx-w3m4](GHSA-8j8q-73xx-w3m4)) ([#10792](#10792)) ([256a253](256a253))
@parseplatformorg

Copy link
Copy Markdown
Contributor

🎉 This change has been released in version 9.10.5-alpha.10

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 15, 2026
parseplatformorg pushed a commit that referenced this pull request Oct 16, 2026
## [9.10.5](9.10.4...9.10.5) (2026-10-16)

### Bug Fixes

* Custom auth adapters that extend the AuthAdapter class accept any authData ([GHSA-rq3w-5c6f-p7wr](GHSA-rq3w-5c6f-p7wr)) ([#10773](#10773)) ([bee4082](bee4082))
* Installation update is written to the installation named by the request's installation ID instead of the addressed object ([GHSA-8j8q-73xx-w3m4](GHSA-8j8q-73xx-w3m4)) ([#10792](#10792)) ([256a253](256a253))
* LiveQuery subscriptions using a `$or` query can receive another user's events, including session tokens ([GHSA-349r-988w-x3jp](GHSA-349r-988w-x3jp)) ([#10776](#10776)) ([a7821c6](a7821c6))
* Login with master key overwrites stored MFA settings of user ([#10771](#10771)) ([28bb53b](28bb53b))
* Malformed query operators `$or`, `$and`, `$nor`, `$options` cause internal server error ([#10775](#10775)) ([c56ccdf](c56ccdf))
* Object update returns the stored value of a field reverted in `beforeSave` to a caller without read access ([GHSA-9rvr-f5hc-9f2f](GHSA-9rvr-f5hc-9f2f)) ([#10788](#10788)) ([0b33504](0b33504))
* Object write with a crafted key can pollute a shared prototype and cause denial of service ([GHSA-rx55-fw4j-pvpx](GHSA-rx55-fw4j-pvpx)) ([#10790](#10790)) ([e895091](e895091))
* Object write with a dot notation key can skip `afterSave` triggers and LiveQuery events ([GHSA-969q-274f-mc7w](GHSA-969q-274f-mc7w)) ([#10786](#10786)) ([6dab17c](6dab17c))
* Option `requestKeywordDenylist` does not apply to query parameters `keys`, `include` and `excludeKeys` ([#10793](#10793)) ([e220f51](e220f51))
* Relation `$relatedTo` query using an operator instead of an object ID bypasses owning-object ACL ([GHSA-58m4-cqvw-4vgh](GHSA-58m4-cqvw-4vgh)) ([#10783](#10783)) ([36af858](36af858))
* SMS MFA login code request saves other login request fields with master privileges ([GHSA-9rh6-r4ph-367v](GHSA-9rh6-r4ph-367v)) ([#10781](#10781)) ([e2a1474](e2a1474))
@parseplatformorg

Copy link
Copy Markdown
Contributor

🎉 This change has been released in version 9.10.5

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 16, 2026
beiguancyc added a commit to beiguancyc/parse-server that referenced this pull request Oct 21, 2026
* release: (158 commits)
  chore(release): 9.10.5 [skip ci]
  empty commit to trigger CI
  chore(release): 9.10.5-alpha.11 [skip ci]
  fix: Option `requestKeywordDenylist` does not apply to query parameters `keys`, `include` and `excludeKeys` (parse-community#10793)
  chore(release): 9.10.5-alpha.10 [skip ci]
  fix: Installation update is written to the installation named by the request's installation ID instead of the addressed object ([GHSA-8j8q-73xx-w3m4](GHSA-8j8q-73xx-w3m4)) (parse-community#10792)
  chore(release): 9.10.5-alpha.9 [skip ci]
  fix: Object write with a crafted key can pollute a shared prototype and cause denial of service ([GHSA-rx55-fw4j-pvpx](GHSA-rx55-fw4j-pvpx)) (parse-community#10790)
  chore(release): 9.10.5-alpha.8 [skip ci]
  fix: Object update returns the stored value of a field reverted in `beforeSave` to a caller without read access ([GHSA-9rvr-f5hc-9f2f](GHSA-9rvr-f5hc-9f2f)) (parse-community#10788)
  chore(release): 9.10.5-alpha.7 [skip ci]
  fix: Object write with a dot notation key can skip `afterSave` triggers and LiveQuery events ([GHSA-969q-274f-mc7w](GHSA-969q-274f-mc7w)) (parse-community#10786)
  chore(release): 9.10.5-alpha.6 [skip ci]
  fix: Relation `$relatedTo` query using an operator instead of an object ID bypasses owning-object ACL ([GHSA-58m4-cqvw-4vgh](GHSA-58m4-cqvw-4vgh)) (parse-community#10783)
  chore(release): 9.10.5-alpha.5 [skip ci]
  fix: SMS MFA login code request saves other login request fields with master privileges ([GHSA-9rh6-r4ph-367v](GHSA-9rh6-r4ph-367v)) (parse-community#10781)
  chore(release): 9.10.5-alpha.4 [skip ci]
  fix: LiveQuery subscriptions using a `$or` query can receive another user's events, including session tokens ([GHSA-349r-988w-x3jp](GHSA-349r-988w-x3jp)) (parse-community#10776)
  chore(release): 9.10.5-alpha.3 [skip ci]
  fix: Malformed query operators `$or`, `$and`, `$nor`, `$options` cause internal server error (parse-community#10775)
  ...

# Conflicts:
#	package-lock.json
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants