[mtrezza]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.

Issue

Batch and direct access requests fail for object IDs without alphanumeric characters or class names without letters

Tasks

• Add tests

Summary by CodeRabbit

• Bug Fixes
  • Fixed REST and batch requests for object IDs containing punctuation or spaces, including -, _, and ~. These IDs can now be used to retrieve, update, and delete objects.
  • Requests for nonexistent objects now return consistent not-found errors, without triggering save hooks or changing existing objects.

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

• Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
• Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
• Group code into logical blocks. Add a short comment before each block to explain its purpose.
• We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
• Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
• Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Essentials
• Run ID: cba1525c-3600-444a-b6de-6c71d1dd6057

📥 Commits

Reviewing files that changed from the base of the PR and between f907c03 and 662f644.

📒 Files selected for processing (4)

• spec/ParseServerRESTController.spec.js
• spec/PromiseRouter.spec.js
• spec/batch.spec.js
• src/PromiseRouter.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

PromiseRouter.match now returns parsed route parameters without validating their values. Tests cover decoded parameters, custom object IDs, and batch requests involving IDs and class names without alphanumeric characters.

Changes

Route Parameter Handling

Layer / File(s)	Summary
Return parsed route parameters src/PromiseRouter.js	PromiseRouter.match returns layer.params directly. It no longer validates className and objectId values or replaces values that fail the former checks with undefined.
Test route parameters and REST behavior spec/PromiseRouter.spec.js, spec/ParseServerRESTController.spec.js, spec/batch.spec.js	Tests cover decoded route parameters, retrieval of a custom object with ID -, and batch behavior for IDs and class names without alphanumeric characters. MongoDB-specific tests check missing-ID GET and PUT behavior with ignoreUndefined: true.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~15 minutes

Merge Risk: ⚪ Minimal · up to 662f6

The change appears ready to merge after normal checks; no actionable merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 7

✅ Passed checks (7 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title begins with the permitted fix: prefix and clearly describes the changes. The first letter after the prefix is capitalized.
Description check	✅ Passed	The description includes the required issue and confirms that tests were added. The ## Approach section is missing, but the description is otherwise sufficiently complete and relevant.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Security Check	✅ Passed	No security vulnerability is introduced by the changed code. PromiseRouter.match now forwards the decoded route strings instead of replacing non-alphanumeric values with undefined. The change only…
Engage In Review Feedback	✅ Passed	PASS: The supplied review metadata reports zero actionable findings and no CodeRabbit review threads. No review feedback required engagement, implementation, or discussion.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.98%. Comparing base (866e82b) to head (662f644).
⚠️ Report is 1 commits behind head on alpha.

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha   #10761      +/-   ##
==========================================
- Coverage   93.99%   93.98%   -0.01%     
==========================================
  Files         193      193              
  Lines       17098    17088      -10     
  Branches      259      259              
==========================================
- Hits        16071    16061      -10     
  Misses       1005     1005              
  Partials       22       22              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[parseplatformorg]

🎉 This change has been released in version 9.10.4-alpha.2

[parseplatformorg]

🎉 This change has been released in version 9.10.4