Running tests on Windows #323

steven-supersolid · 2016-02-09T16:18:52Z

Running npm test gives an error with babel-node / babel-instanbul

I added cross-env to enable setting environment variables in npm script. I want to submit a PR with this change and a fix to get babel working if possible.

C:\development\parse-server-fork>npm test

[email protected] pretest C:\development\parse-server-fork
cross-env MONGODB_VERSION=${MONGODB_VERSION:=3.0.8} ./node_modules/.bin/mongodb-runner start

Starting a MongoDB deployment to test against...
[email protected] test C:\development\parse-server-fork
cross-env NODE_ENV=test TESTING=1 ./node_modules/.bin/babel-node ./node_modules/.bin/babel-istanbul cover -x /spec/ ./node_modules/.bin/jasmine

C:\development\parse-server-fork\node_modules.bin\babel-istanbul:4
case uname in
^^^^

SyntaxError: Unexpected token case
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:374:25)
at Object.Module._extensions..js (module.js:417:10)
at Module.load (module.js:344:32)
at Function.Module._load (module.js:301:12)
at Function.Module.runMain (module.js:442:10)
at C:\development\parse-server-fork\node_modules\babel-cli\lib_babel-node.js:161:27
at Object. (C:\development\parse-server-fork\node_modules\babel-cli\lib_babel-node.js:162:7)
at Module._compile (module.js:410:26)
at Object.Module._extensions..js (module.js:417:10)
npm ERR! Test failed. See above for more details.

The text was updated successfully, but these errors were encountered:

steven-supersolid · 2016-02-10T11:30:09Z

#335

nlutsenko · 2016-02-12T03:08:31Z

Looks like this is done now.

aneeshd16 · 2016-03-04T05:56:28Z

With new changes, this fails again on Windows
https://github.com/ParsePlatform/parse-server/blob/master/package.json#L59
probably because of the if condition

flovilmart · 2016-03-04T13:46:08Z

What version of Windows do you use? What command interpreter?

aneeshd16 · 2016-03-04T13:49:32Z

Windows 10 64 bit
PowerShell:


> [email protected] pretest B:\Projects\Parse Server\parse-server
> cross-env MONGODB_VERSION=${MONGODB_VERSION:=3.0.8} ./node_modules/.bin/mongodb-runner start


> [email protected] test B:\Projects\Parse Server\parse-server
> cross-env NODE_ENV=test TESTING=1 ./node_modules/.bin/babel-node $(if [ "$CODE_COVERAGE" = "1" ]; then echo './node_modules/babel-istanbul/lib/cli.js cover -x **/spec/**'; fi;) ./node_modules/jasmine/bin/jasmine.js

./node_modules/jasmine/bin/jasmine.js was unexpected at this time.

B:\Projects\Parse Server\parse-server>  "B:\Projects\Parse Server\parse-server\node_modules\.bin\\node.exe"  "B:\Projects\Parse Server\parse-server\node_modules\.bin\\..\cross-env\bin\cross-env.js" NODE_ENV=test TESTING=1 ./node_modules/.bin/babel-node $(if [ "$CODE_COVERAGE" = "1" ]; then echo './node_modules/babel-istanbul/lib/cli.js cover -x **/spec/**'; fi;) ./node_modules/jasmine/bin/jasmine.js
npm ERR! Test failed.  See above for more details.

Same output with cmd.

aneeshd16 · 2016-03-04T13:54:03Z

Also, since shebangs are not supported on Windows, npm start and npm run dev do not work either.
Why not set "start": "./bin/parse-server" to `"start": "node ./bin/parse-server"?

steven-supersolid · 2016-03-04T13:58:33Z

I get the same issue. Suggest removing the if and having a separate npm script for coverage as a quick fix, plus the other changes would be nice too.

I can make a PR next week unless @aneeshd16 wants to take it before then?

flovilmart · 2016-03-04T14:00:00Z

let me think about something

flovilmart · 2016-03-04T14:39:18Z

See #831

steven-supersolid · 2016-03-04T20:09:15Z

Nice 👍

aneeshd16 · 2016-03-05T05:24:19Z

@steven-supersolid Does this work for you? It still throws an error on my system:


> [email protected] pretest B:\Projects\Parse Server\parse-server
> cross-env MONGODB_VERSION=${MONGODB_VERSION:=3.0.8} ./node_modules/.bin/mongodb-runner start


> [email protected] test B:\Projects\Parse Server\parse-server
> cross-env NODE_ENV=test TESTING=1 ./node_modules/.bin/babel-node $COVERAGE_OPTION ./node_modules/jasmine/bin/jasmine.js

module.js:339
    throw err;
    ^

Error: Cannot find module 'B:\Projects\Parse Server\parse-server\$COVERAGE_OPTION'
    at Function.Module._resolveFilename (module.js:337:15)
    at Function.Module._load (module.js:287:25)
    at Function.Module.runMain (module.js:467:10)
    at B:\Projects\Parse Server\parse-server\node_modules\babel-cli\lib\_babel-node.js:161:27
    at Object.<anonymous> (B:\Projects\Parse Server\parse-server\node_modules\babel-cli\lib\_babel-node.js:162:7)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Function.Module.runMain (module.js:467:10)
npm ERR! Test failed.  See above for more details.

Use `npm run test:win` to run tests on Windows. Fixes parse-community#323. Variables like `$COVERAGE_OPTION` are not supported in Windows.

steven-supersolid · 2016-03-07T13:40:12Z

Yes I got the same issue, also npm run coverage doesn't work either but #886 does allow the tests to be run (I get a TypeError on a test but not sure if that is a problem on my end)

aneeshd16 · 2016-03-07T13:59:42Z

Yes, I get the same error. I too thought it was only on my end

B:\Projects\Parse Server\parse-server\spec\FileLoggerAdapter.spec.js:38
        expect(results[0].message).toEqual('testing info logs');
                         ^

TypeError: Cannot read property 'message' of undefined
    at B:\Projects\Parse Server\parse-server\spec\FileLoggerAdapter.spec.js:38:26
    at ParsePromise.<anonymous> (B:\Projects\Parse Server\parse-server\src\Adapters\Logger\FileLoggerAdapter.js:9:17440)
    at ParsePromise.wrappedResolvedCallback (B:\Projects\Parse Server\parse-server\node_modules\parse\lib\node\ParsePromise.js:139:41)
    at ParsePromise.resolve (B:\Projects\Parse Server\parse-server\node_modules\parse\lib\node\ParsePromise.js:72:36)
    at resolveOne (B:\Projects\Parse Server\parse-server\node_modules\parse\lib\node\ParsePromise.js:471:29)
    at ParsePromise.object.then.errors.(anonymous function) (B:\Projects\Parse Server\parse-server\node_modules\parse\lib\node\ParsePromise.js:480:13)
    at ParsePromise.wrappedResolvedCallback (B:\Projects\Parse Server\parse-server\node_modules\parse\lib\node\ParsePromise.js:139:41)
    at ParsePromise.resolve (B:\Projects\Parse Server\parse-server\node_modules\parse\lib\node\ParsePromise.js:72:36)
    at ReadFileContext.callback (B:\Projects\Parse Server\parse-server\src\Adapters\Logger\FileLoggerAdapter.js:9:16189)
    at FSReqWrap.readFileAfterOpen [as oncomplete] (fs.js:303:13)

Seems like results is undefined. Interestingly, this error does not occur on my Ubuntu machine.

flovilmart · 2016-03-07T14:00:58Z

there is a big change a path.resolve didn't use path.separator

aneeshd16 · 2016-03-09T05:54:16Z

Changing promise.resolve([]) to promise.reject([]) here https://github.com/ParsePlatform/parse-server/blob/master/src/Adapters/Logger/FileLoggerAdapter.js#L191 causes the test to rightfully fail and allows running of the rest of the tests. However, i do not know the impact of this change on other code. Logically, if there is an error, the promise should be rejected, right? @flovilmart

flovilmart · 2016-03-10T04:42:11Z

It depends if you want to propagate the error or just swallow it

aneeshd16 · 2016-03-10T05:49:00Z

Okay modified the test to fail if it gets an empty array: #946

aneeshd16 · 2016-03-11T06:43:21Z

I have been playing around with FileLoggerAdapter and there are multiple problems that need to be solved:

Using path.resolve(<filename>) works for generating a valid Windows filename from the nix ones.
But, the _getFileName() (Link to code) method outputs a filename that contains the : character which cannot be part of a filename on Windows.
How do we solve this? If we replace all : with another character (like -) it will be able to write the file on disk. But people who have already deployed on *nix systems won't be able to read old logs.
Can we detect the OS and set the filename accordingly? What are the implications for having different filenames for logs across OSes?
After I had implemented these fixes, the tests failed again because of this: https://github.com/ParsePlatform/parse-server/blob/master/spec/FileLoggerAdapter.spec.js#L8
Stuff I tried to solve this:

Added path.resolve. Go the error:

Stack:
    Error: EPERM: operation not permitted, lstat 'B:\Projects\Parse Server\parse-server\test_logs\2016-03-10T18-30-00.000Z.info'
        at Error (native)
        at Object.fs.lstatSync (fs.js:839:18)
        at B:\Projects\Parse Server\parse-server\spec\FileLoggerAdapter.spec.js:12:13
        at Array.forEach (native)
        at deleteFolderRecursive (B:\Projects\Parse Server\parse-server\spec\FileLoggerAdapter.spec.js:10:26)
        at Object.<anonymous> (B:\Projects\Parse Server\parse-server\spec\FileLoggerAdapter.spec.js:53:5)

Used rimraf
1. Tried rimraf async, passed the done() method as the callback to rimraf. got the error: Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
2. Tried rimraf.sync() and hit this issue Windows support (ENOTEMPTY issues) isaacs/rimraf#72

I am starting to wonder if it is really worth the trouble to fix this.

steven-supersolid · 2016-03-11T15:06:50Z

I didn't get anywhere with this either. It seems the logs are not even being written on Windows and for me I don't mind that parse-server will not run on Windows, but I do want the tests to run.

nlutsenko closed this as completed Feb 12, 2016

flovilmart mentioned this issue Mar 4, 2016

Better support for windows builds #831

Merged

aneeshd16 added a commit to aneeshd16/parse-server that referenced this issue Mar 7, 2016

Added test command for Windows support

5b1cf98

Use `npm run test:win` to run tests on Windows. Fixes parse-community#323. Variables like `$COVERAGE_OPTION` are not supported in Windows.

aneeshd16 mentioned this issue Mar 7, 2016

Added test command for Windows support #886

Merged

snyk-bot mentioned this issue Mar 11, 2020

[Snyk] Upgrade uuid from 3.3.3 to 3.4.0 #6491

Merged

mtrezza mentioned this issue Apr 5, 2021

GitHub actions #7035

Merged

snyk-bot mentioned this issue Feb 18, 2022

refactor: upgrade winston-daily-rotate-file from 4.5.5 to 4.6.0 #7816

Merged

snyk-bot mentioned this issue Nov 2, 2022

refactor: Upgrade jwks-rsa from 2.1.4 to 2.1.5 #8278

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Running tests on Windows #323

Running tests on Windows #323

steven-supersolid commented Feb 9, 2016

steven-supersolid commented Feb 10, 2016

nlutsenko commented Feb 12, 2016

aneeshd16 commented Mar 4, 2016

flovilmart commented Mar 4, 2016

aneeshd16 commented Mar 4, 2016

aneeshd16 commented Mar 4, 2016

steven-supersolid commented Mar 4, 2016

flovilmart commented Mar 4, 2016

flovilmart commented Mar 4, 2016

steven-supersolid commented Mar 4, 2016

aneeshd16 commented Mar 5, 2016

steven-supersolid commented Mar 7, 2016

aneeshd16 commented Mar 7, 2016

flovilmart commented Mar 7, 2016

aneeshd16 commented Mar 9, 2016

flovilmart commented Mar 10, 2016

aneeshd16 commented Mar 10, 2016

aneeshd16 commented Mar 11, 2016

steven-supersolid commented Mar 11, 2016

Running tests on Windows #323

Running tests on Windows #323

Comments

steven-supersolid commented Feb 9, 2016

steven-supersolid commented Feb 10, 2016

nlutsenko commented Feb 12, 2016

aneeshd16 commented Mar 4, 2016

flovilmart commented Mar 4, 2016

aneeshd16 commented Mar 4, 2016

aneeshd16 commented Mar 4, 2016

steven-supersolid commented Mar 4, 2016

flovilmart commented Mar 4, 2016

flovilmart commented Mar 4, 2016

steven-supersolid commented Mar 4, 2016

aneeshd16 commented Mar 5, 2016

steven-supersolid commented Mar 7, 2016

aneeshd16 commented Mar 7, 2016

flovilmart commented Mar 7, 2016

aneeshd16 commented Mar 9, 2016

flovilmart commented Mar 10, 2016

aneeshd16 commented Mar 10, 2016

aneeshd16 commented Mar 11, 2016

steven-supersolid commented Mar 11, 2016