Skip to content

Commit

Permalink
feat: add support for Node 16 (#7707)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Removes official Node 15 support which has reached it end-of-life date.
  • Loading branch information
marvinroger authored Nov 18, 2021
1 parent ae99b92 commit 45cc58c
Show file tree
Hide file tree
Showing 6 changed files with 179 additions and 254 deletions.
28 changes: 14 additions & 14 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
branches:
- '**'
env:
NODE_VERSION: 14.18.1
NODE_VERSION: 16.13.0
PARSE_SERVER_TEST_TIMEOUT: 20000
jobs:
check-ci:
Expand Down Expand Up @@ -105,43 +105,43 @@ jobs:
MONGODB_VERSION: 5.0.3
MONGODB_TOPOLOGY: replicaset
MONGODB_STORAGE_ENGINE: wiredTiger
NODE_VERSION: 14.18.1
NODE_VERSION: 16.13.0
- name: MongoDB 4.4, ReplicaSet, WiredTiger
MONGODB_VERSION: 4.4.10
MONGODB_TOPOLOGY: replicaset
MONGODB_STORAGE_ENGINE: wiredTiger
NODE_VERSION: 14.18.1
NODE_VERSION: 16.13.0
- name: MongoDB 4.2, ReplicaSet, WiredTiger
MONGODB_VERSION: 4.2.17
MONGODB_TOPOLOGY: replicaset
MONGODB_STORAGE_ENGINE: wiredTiger
NODE_VERSION: 14.18.1
NODE_VERSION: 16.13.0
- name: MongoDB 4.0, ReplicaSet, WiredTiger
MONGODB_VERSION: 4.0.27
MONGODB_TOPOLOGY: replicaset
MONGODB_STORAGE_ENGINE: wiredTiger
NODE_VERSION: 14.18.1
NODE_VERSION: 16.13.0
- name: MongoDB 4.0, Standalone, MMAPv1
MONGODB_VERSION: 4.0.27
MONGODB_TOPOLOGY: standalone
MONGODB_STORAGE_ENGINE: mmapv1
NODE_VERSION: 14.18.1
NODE_VERSION: 16.13.0
- name: Redis Cache
PARSE_SERVER_TEST_CACHE: redis
MONGODB_VERSION: 4.4.10
MONGODB_TOPOLOGY: standalone
MONGODB_STORAGE_ENGINE: wiredTiger
NODE_VERSION: 14.18.1
NODE_VERSION: 16.13.0
- name: Node 12
MONGODB_VERSION: 4.4.10
MONGODB_TOPOLOGY: standalone
MONGODB_STORAGE_ENGINE: wiredTiger
NODE_VERSION: 12.22.7
- name: Node 15
- name: Node 14
MONGODB_VERSION: 4.4.10
MONGODB_TOPOLOGY: standalone
MONGODB_STORAGE_ENGINE: wiredTiger
NODE_VERSION: 15.14.0
NODE_VERSION: 14.18.1
fail-fast: false
name: ${{ matrix.name }}
timeout-minutes: 15
Expand Down Expand Up @@ -183,19 +183,19 @@ jobs:
include:
- name: PostgreSQL 11, PostGIS 3.0
POSTGRES_IMAGE: postgis/postgis:11-3.0
NODE_VERSION: 14.18.1
NODE_VERSION: 16.13.0
- name: PostgreSQL 11, PostGIS 3.1
POSTGRES_IMAGE: postgis/postgis:11-3.1
NODE_VERSION: 14.18.1
NODE_VERSION: 16.13.0
- name: PostgreSQL 12, PostGIS 3.1
POSTGRES_IMAGE: postgis/postgis:12-3.1
NODE_VERSION: 14.18.1
NODE_VERSION: 16.13.0
- name: PostgreSQL 13, PostGIS 3.1
POSTGRES_IMAGE: postgis/postgis:13-3.1
NODE_VERSION: 14.18.1
NODE_VERSION: 16.13.0
- name: PostgreSQL 14, PostGIS 3.1
POSTGRES_IMAGE: postgis/postgis:14-3.1
NODE_VERSION: 14.18.1
NODE_VERSION: 16.13.0
fail-fast: false
name: ${{ matrix.name }}
timeout-minutes: 15
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,7 @@ Parse Server is continuously tested with the most recent releases of Node.js to
|------------|----------------|-------------|---------------|
| Node.js 12 | 12.22.7 | April 2022 | ✅ Yes |
| Node.js 14 | 14.18.1 | April 2023 | ✅ Yes |
| Node.js 15 | 15.14.0 | June 2021 | ✅ Yes |
| Node.js 16 | 16.x.x | April 2024 | ❌ Not tested |
| Node.js 16 | 16.13.0 | April 2024 | ✅ Yes |

This comment has been minimized.

Copy link
@TomKremer

TomKremer Dec 8, 2021

Hello, this is what I get when trying alpha 12
npm WARN EBADENGINE Unsupported engine { npm WARN EBADENGINE package: '[email protected]', npm WARN EBADENGINE required: { node: '>=12.20.0 <16' }, npm WARN EBADENGINE current: { node: 'v16.13.0', npm: '8.1.3' } npm WARN EBADENGINE }

This comment has been minimized.

Copy link
@mtrezza

mtrezza Dec 8, 2021

Member

Fixed, see #7738


#### MongoDB
Parse Server is continuously tested with the most recent releases of MongoDB to ensure compatibility. We follow the [MongoDB support schedule](https://www.mongodb.com/support-policy) and only test against versions that are officially supported and have not reached their end-of-life date.
Expand Down
9 changes: 4 additions & 5 deletions ci/ciCheck.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'use strict'
'use strict';

const CiVersionCheck = require('./CiVersionCheck');
const mongoVersionList = require('mongodb-version-list');
Expand All @@ -14,9 +14,8 @@ async function check() {
* Check the MongoDB versions used in test environments.
*/
async function checkMongoDbVersions() {

const releasedVersions = await new Promise((resolve, reject) => {
mongoVersionList(function(error, versions) {
mongoVersionList(function (error, versions) {
if (error) {
reject(error);
}
Expand Down Expand Up @@ -47,7 +46,6 @@ async function checkMongoDbVersions() {
* Check the Nodejs versions used in test environments.
*/
async function checkNodeVersions() {

const allVersions = await allNodeVersions();
const releasedVersions = allVersions.versions;

Expand All @@ -62,7 +60,8 @@ async function checkNodeVersions() {
ignoreReleasedVersions: [
'<12.0.0', // These versions have reached their end-of-life support date
'>=13.0.0 <14.0.0', // These versions have reached their end-of-life support date
'>=16.0.0', // This version has not been officially released yet
'>=15.0.0 <16.0.0', // These versions have reached their end-of-life support date
'>=17.0.0', // These versions are not officially supported yet
],
}).check();
}
Expand Down
Loading

0 comments on commit 45cc58c

Please sign in to comment.