Repository navigation
fix: Bump parse from 8.6.1 to 8.6.2 - #612
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughThe project updates its declared ChangesDependency version update
Estimated code review effort: 2 (Simple) | ~8 minutes Merge Risk: ⚪ Minimal · up to This update changes dependency versions without an identified application behavior issue. No actionable merge-blocking risk is evident. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 11 11
Lines 1841 1841
=======================================
Hits 1826 1826
Misses 15 15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
## [8.5.5](8.5.4...8.5.5) (2026-09-23) ### Bug Fixes * Bump parse from 8.6.1 to 8.6.2 ([#612](#612)) ([fd7b8ec](fd7b8ec))
|
🎉 This change has been released in version 8.5.5 |
Pull Request
Issue
The production dependency
parse8.6.1 pinswsexactly at 8.21.0, which is affected by:maxFragmentslimit, so the guard never fires, while each small fragment is kept as a separate Buffer. Affects ws before 8.21.1, patched in 8.21.1. It was reported in Default maxFragments still allows memory-exhaustion DoS (incomplete GHSA-96hv-2xvq-fx4p fix) websockets/ws#2331 as an incomplete fix of GHSA-96hv-2xvq-fx4p, which fix: Bump parse from 8.6.0 to 8.6.1 #611 addressed by upgrading tows8.21.0.The advisory is still marked as unreviewed in the GitHub Advisory Database, so Dependabot does not raise an alert for it.
Because
parsepinswsexactly,wscannot be updated on its own.parse8.6.2 is the first release that depends on a patchedwsversion (8.21.3).Approach
Bumps the
parseproduction dependency from 8.6.1 to 8.6.2, pinned to an exact version. Manifest and lock file only — no code changes. This follows the same approach as #611.The lock file changes are limited to
parseand its own dependencies:parse8.6.1 → 8.6.2ws8.21.0 → 8.21.3 (the onlywsinstance in the dependency tree)Changes
maxFragmentslimit (fix: count empty continuation frames toward the maxFragments limit websockets/ws#2329). The defaultmaxBufferedChunksis lowered from 1048576 to 262144, and the defaultmaxFragmentsfrom 131072 to 16384. Connections that exceed these limits are still closed with code 1008.wsserver now rejects permessage-deflate offers whoseclient_max_window_bitsis smaller than its configuredclientMaxWindowBits. This only affectswsservers.lib/node, whichparse/noderesolves to) matches 8.6.1 except for the version string.Breaking Changes
None.
parse8.6.2 declares the sameengines.nodeas 8.6.1 (>=20.19.0 <21 || >=22.13.0 <23 || >=24.1.0 <25), andws8.21.3 requires Node>=10.0.0, so the upgrade adds no new Node version constraint.engines.nodein this repository is unchanged.Code Changes Required
None — the upgrade is a drop-in replacement. This adapter imports
parse/nodeonly forParse.Error: the constructor, thePUSH_MISCONFIGUREDandOTHER_CAUSEcodes, andinstanceofchecks. That API is unchanged, and the existing APNS, APNSNative, FCM and ParsePushAdapter specs cover it. The adapter does not use LiveQuery, so it loadswsbut never opens a WebSocket connection with it. The full test suite passes locally withparse8.6.2 (163 of 163 specs).Tasks
No tasks apply (manifest and lock file only dependency update; existing tests cover the used API).
Summary by CodeRabbit