Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Info panel not showing when some apps miss infoPanel config #2627

Open
wants to merge 3 commits into
base: alpha
Choose a base branch
from

Conversation

vardhan0604
Copy link
Contributor

New Pull Request Checklist

Issue Description

Closes: #2623

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

Copy link

uffizzi-cloud bot commented Nov 3, 2024

Uffizzi Ephemeral Environment deployment-57881

⌚ Updated Nov 03, 2024, 21:35 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2627

📄 View Application Logs etc.

What is Uffizzi? Learn more

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Show panel" button doesn't appear, when having a second app in dashboard config. Before this PR, a workaround was to add an empty panel "infoPanel": [],, but that doesn't work anymore either. Could you please verify the fix with the following configs:

1 app w/ panel:

{
  "apps": [
    {
      "serverURL": "https://app1.example.com",
      "appId": "appId1",
      "masterKey": "masterKey",
      "appName": "app1",
      "infoPanel": [
        {
          "title": "User Details",
          "classes": ["_User"],
          "cloudCodeFunction": "user"
        }
      ]
    }
  ]
}

2 apps, 1 w/ panel, 1 w/o panel:

{
  "apps": [
    {
      "serverURL": "https://app1.example.com",
      "appId": "appId1",
      "masterKey": "masterKey",
      "appName": "app1",
      "infoPanel": [
        {
          "title": "User Details",
          "classes": ["_User"],
          "cloudCodeFunction": "user"
        }
      ]
    },
    {
      "serverURL": "https://app2.example.com",
      "appId": "appId2",
      "masterKey": "masterKey",
      "appName": "app2"
    }
  ]
}

2 apps, 1 w/ panel, 1 w/ empty panel:

{
  "apps": [
    {
      "serverURL": "https://app1.example.com",
      "appId": "appId1",
      "masterKey": "masterKey",
      "appName": "app1",
      "infoPanel": [
        {
          "title": "User Details",
          "classes": ["_User"],
          "cloudCodeFunction": "user"
        }
      ]
    },
    {
      "serverURL": "https://app2.example.com",
      "appId": "appId2",
      "masterKey": "masterKey",
      "appName": "app2",
      "infoPanel": []
    }
  ]
}

2 apps, 2 w/ panel in same class:

{
  "apps": [
    {
      "serverURL": "https://app1.example.com",
      "appId": "appId1",
      "masterKey": "masterKey",
      "appName": "app1",
      "infoPanel": [
        {
          "title": "User Details",
          "classes": ["_User"],
          "cloudCodeFunction": "user"
        }
      ]
    },
    {
      "serverURL": "https://app2.example.com",
      "appId": "appId2",
      "masterKey": "masterKey",
      "appName": "app2",
      "infoPanel": [
       {
          "title": "User Details",
          "classes": ["_User"],
          "cloudCodeFunction": "user"
        }
      ]
    }
  ]
}

2 apps, 2 w/ panel in different classes:

{
  "apps": [
    {
      "serverURL": "https://app1.example.com",
      "appId": "appId1",
      "masterKey": "masterKey",
      "appName": "app1",
      "infoPanel": [
        {
          "title": "User Details",
          "classes": ["_User"],
          "cloudCodeFunction": "user"
        }
      ]
    },
    {
      "serverURL": "https://app2.example.com",
      "appId": "appId2",
      "masterKey": "masterKey",
      "appName": "app2",
      "infoPanel": [
        {
          "title": "Installation Details",
          "classes": ["_Installation"],
          "cloudCodeFunction": "installation"
        }
      ]
    }
  ]
}

@vardhan0604
Copy link
Contributor Author

@mtrezza, it’s working locally for me, but I'm not sure why it’s not working for you. I’ve pushed everything.
This is my config i used in this demo

{
  "apps": [
    {
      "serverURL": "http://localhost:1337/parse",
      "appId": "1234",
      "masterKey": "12345",
      "appName": "MyApp",
      "infoPanel": [
        {
          "title": "User Details",
          "classes": ["_User"],
          "cloudCodeFunction": "user"
        },
        {
          "title": "Purchase Details",
          "classes": ["Purchase"],
          "cloudCodeFunction": "purchase"
        },
        {
          "title": "systumm h ladle",
          "classes": ["systum"],
          "cloudCodeFunction": "systum"
        }
      ]
    },
    {
      "serverURL": "https://app2.example.com",
      "appId": "appId2",
      "masterKey": "masterKey",
      "appName": "app2"
    }
  ]
}

Screen.Recording.2024-11-07.005039.mp4

@mtrezza
Copy link
Member

mtrezza commented Nov 7, 2024

Did you try out all the configs from my previous comment? Some do not seem to work.

@vardhan0604
Copy link
Contributor Author

Did you try out all the configs from my previous comment? Some do not seem to work.

Yes @mtrezza , I tried all the configurations, and they seem to be working on my end. Could you let me know which specific ones aren’t working for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Info panel not showing when some apps miss infoPanel config
2 participants