fix: App metrics for user and installation counts show dash #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Uffizzi Ephemeral Environment
|
|
It will still show wrong number because of parse-community/parse-server#8502, but the fix is for this issue so this issue is fixed with this PR. |
|
So what should we do with this PR? |
|
Since it is fixing the UI problem, we should merge it as of now. |
patelmilanun
approved these changes
Feb 21, 2024
mtrezza
previously approved these changes
Feb 22, 2024
mtrezza
changed the title
|
What's the issue that this PR fixes? In the current dashboard version it seems to show dashes only for 1 or 2 seconds and then shows the numbers. So the dashes just seem to be a placeholder until the app metrics are loaded? |
|
I've checked that I installed the NPM package and set up an app with Express.js. But I'm seeing a '-' here that shouldn't be. 
|
|
Looking at the code, if there is only 1 app, the dashboard should navigate directly to the data browser. If there are multiple apps, then the code change shouldn't have any effect. In your case, if you have only 1 app, then maybe the bug is that it doesn't navigate to the data browser? How do you get to that app overview page, do you see it after login or when you are in the data browser and click on the "Your Apps" menu? |
|
I have tested with this uffizzi link. After logged in this is the main page I am getting. Is this behaviour expected? 
|
|
I don't think so. From the code I'd say that if there is only 1 app it should go directly to the data browser. It doesn't go there, so there may be an issue with the redirect code. That explains why the stats don't update. The fix in this PR doesn't seem to make much sense, because it updates the stats and then immediately auto-redirects, if there is only 1 app. I think the auto-redirect is actually a strange behavior. Why not always show the apps overview page for consistency and entirely remove the auto-redirect code. What do you think? |
|
Since redirections never seem to work for me, I've gotten used to relying on the menu. I agree with you about removing the redirection code to ensure consistency. |
parseplatformorg
pushed a commit
that referenced
this pull request
Feb 26, 2024
# [5.4.0-alpha.6](5.4.0-alpha.5...5.4.0-alpha.6) (2024-02-26) ### Bug Fixes * App metrics for user and installation counts show dash ([#2528](#2528)) ([850d7b3](850d7b3))
|
🎉 This change has been released in version 5.4.0-alpha.6 |
davimacedo
pushed a commit
to back4app/parse-dashboard
that referenced
this pull request
Apr 4, 2024
* feat: Add refresh indicator to Cloud Config page (parse-community#2505) * chore(release): 5.3.0-alpha.2 [skip ci] # [5.3.0-alpha.2](parse-community/parse-dashboard@5.3.0-alpha.1...5.3.0-alpha.2) (2023-10-18) ### Features * Add refresh indicator to Cloud Config page ([parse-community#2505](parse-community#2505)) ([a10d1f0](parse-community@a10d1f0)) * release * chore(release): 5.3.0 [skip ci] # [5.3.0](parse-community/parse-dashboard@5.2.0...5.3.0) (2023-11-16) ### Bug Fixes * Adding a file when adding a new row in the data browser doesn't show filename ([parse-community#2471](parse-community#2471)) ([5bbb94e](parse-community@5bbb94e)) * File extension is hidden in file field when editing object in modal dialog in data browser ([parse-community#2472](parse-community#2472)) ([8df4e4d](parse-community@8df4e4d)) * Incorrect highlight maker position in class list in data browser ([parse-community#2490](parse-community#2490)) ([8c28d24](parse-community@8c28d24)) * Pasting location coordinates into field of type `GeoPoint` does not work in data browser ([parse-community#2464](parse-community#2464)) ([a8ce343](parse-community@a8ce343)) * Selecting a saved filter in data browser also highlights other filters with equal names ([parse-community#2466](parse-community#2466)) ([35360fe](parse-community@35360fe)) * Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([parse-community#2457](parse-community#2457)) ([5acac3f](parse-community@5acac3f)) ### Features * Add Cloud Function execution on Parse Object in data browser ([parse-community#2409](parse-community#2409)) ([996ce91](parse-community@996ce91)) * Add parameter `selectedField` to script payload to determine which object field was selected when script was invoked ([parse-community#2483](parse-community#2483)) ([e98d653](parse-community@e98d653)) * Add refresh button to Cloud Config page ([parse-community#2480](parse-community#2480)) ([be212b0](parse-community@be212b0)) * Add security checks page ([parse-community#2491](parse-community#2491)) ([103b9c6](parse-community@103b9c6)) * Add support for confirmation dialog before script execution in data browser ([parse-community#2481](parse-community#2481)) ([64d3913](parse-community@64d3913)) * Add typing with auto-complete to select a filter field in the data browser ([parse-community#2463](parse-community#2463)) ([257f76b](parse-community@257f76b)) * Reopen last opened class when navigating to data browser ([parse-community#2468](parse-community#2468)) ([3d7148e](parse-community@3d7148e)) ### Reverts * fix: Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([parse-community#2457](parse-community#2457)) ([parse-community#2477](parse-community#2477)) ([2f1d84e](parse-community@2f1d84e)) * release * chore(release): 5.4.0-beta.1 [skip ci] # [5.4.0-beta.1](parse-community/parse-dashboard@5.3.0...5.4.0-beta.1) (2023-11-16) ### Features * Add refresh indicator to Cloud Config page ([parse-community#2505](parse-community#2505)) ([a10d1f0](parse-community@a10d1f0)) * refactor: Security upgrade js-beautify from 1.14.6 to 1.14.10 (parse-community#2513) * chore(release): 5.4.0-alpha.1 [skip ci] # [5.4.0-alpha.1](parse-community/parse-dashboard@5.3.0...5.4.0-alpha.1) (2023-12-02) ### Features * Add refresh indicator to Cloud Config page ([parse-community#2505](parse-community#2505)) ([a10d1f0](parse-community@a10d1f0)) * feat: Execute script for selected rows (parse-community#2508) * chore(release): 5.4.0-alpha.2 [skip ci] # [5.4.0-alpha.2](parse-community/parse-dashboard@5.4.0-alpha.1...5.4.0-alpha.2) (2023-12-16) ### Features * Execute script for selected rows ([parse-community#2508](parse-community#2508)) ([5d9901e](parse-community@5d9901e)) * fix: Dashboard crashes if Parse Server Cloud Function script returns object (parse-community#2516) * chore(release): 5.4.0-alpha.3 [skip ci] # [5.4.0-alpha.3](parse-community/parse-dashboard@5.4.0-alpha.2...5.4.0-alpha.3) (2023-12-16) ### Bug Fixes * Dashboard crashes if Parse Server Cloud Function script returns object ([parse-community#2516](parse-community#2516)) ([5de08f8](parse-community@5de08f8)) * fix: Data browser redirects to wrong class when changing app (parse-community#2526) * chore(release): 5.4.0-alpha.4 [skip ci] # [5.4.0-alpha.4](parse-community/parse-dashboard@5.4.0-alpha.3...5.4.0-alpha.4) (2024-02-15) ### Bug Fixes * Data browser redirects to wrong class when changing app ([parse-community#2526](parse-community#2526)) ([7713f54](parse-community@7713f54)) * fix: Open pointer in new tab in data browser not working when mount path is not root (parse-community#2527) * chore(release): 5.4.0-alpha.5 [skip ci] # [5.4.0-alpha.5](parse-community/parse-dashboard@5.4.0-alpha.4...5.4.0-alpha.5) (2024-02-18) ### Bug Fixes * Open pointer in new tab in data browser not working when mount path is not root ([parse-community#2527](parse-community#2527)) ([2f4081f](parse-community@2f4081f)) * fix: App metrics for user and installation counts show dash (parse-community#2528) * chore(release): 5.4.0-alpha.6 [skip ci] # [5.4.0-alpha.6](parse-community/parse-dashboard@5.4.0-alpha.5...5.4.0-alpha.6) (2024-02-26) ### Bug Fixes * App metrics for user and installation counts show dash ([parse-community#2528](parse-community#2528)) ([850d7b3](parse-community@850d7b3)) * feat: Add descriptive statistics for number cells in data browser (parse-community#2529) * chore(release): 5.4.0-alpha.7 [skip ci] # [5.4.0-alpha.7](parse-community/parse-dashboard@5.4.0-alpha.6...5.4.0-alpha.7) (2024-02-26) ### Features * Add descriptive statistics for number cells in data browser ([parse-community#2529](parse-community#2529)) ([ead9ec4](parse-community@ead9ec4)) * fix: Config page fails to load (parse-community#2531) * chore(release): 5.4.0-alpha.8 [skip ci] # [5.4.0-alpha.8](parse-community/parse-dashboard@5.4.0-alpha.7...5.4.0-alpha.8) (2024-02-29) ### Bug Fixes * Config page fails to load ([parse-community#2531](parse-community#2531)) ([d721b7c](parse-community@d721b7c)) * feat: Add Node 20 support; remove Node 14, 16 support (parse-community#2532) * feat: Add Node 20 support; remove Node 14, 16 support (parse-community#2535) BREAKING CHANGE: Removes support for Node 14 and 16 * chore(release): 6.0.0-alpha.1 [skip ci] # [6.0.0-alpha.1](parse-community/parse-dashboard@5.4.0-alpha.8...6.0.0-alpha.1) (2024-03-05) ### Features * Add Node 20 support; remove Node 14, 16 support ([parse-community#2532](parse-community#2532)) ([578a339](parse-community@578a339)) * Add Node 20 support; remove Node 14, 16 support ([parse-community#2535](parse-community#2535)) ([5c90f2d](parse-community@5c90f2d)) ### BREAKING CHANGES * Removes support for Node 14 and 16 ([5c90f2d](5c90f2d)) * refactor: Security upgrade express from 4.18.1 to 4.19.2 (parse-community#2539) * ci: Fix nginx config for preview environment (parse-community#2542) * refactor: Upgrade to npm lockfile version 3 (parse-community#2543) * fix: make cursor pointer for support more icon * fix: more icon cursor pointer * fix: remove console from B4aNotification * feat: add light themed b4aEmptyState * fix: B4aObjectPicker app crash when class exists not * fix: cloudcode empty states * fix: reduce size to remove scrollbar * fix: remove extra space from REST Console top * fix: dark themed dropdown arrow * fix: error modal * feat: add logRocket --------- Co-authored-by: patelmilanun <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Manuel Trezza <[email protected]> Co-authored-by: Parse Platform <[email protected]> Co-authored-by: Ashish Baravaliya <[email protected]> Co-authored-by: Corey <[email protected]>
parseplatformorg
pushed a commit
that referenced
this pull request
May 16, 2024
# [6.0.0-beta.1](5.4.0...6.0.0-beta.1) (2024-05-16) ### Bug Fixes * App metrics for user and installation counts show dash ([#2528](#2528)) ([850d7b3](850d7b3)) * Class Level Permissions dialog throws error `TypeError: ce.current is null` for newly created class ([#2549](#2549)) ([27ed692](27ed692)) * Config page fails to load ([#2531](#2531)) ([d721b7c](d721b7c)) * Dashboard crashes if Parse Server Cloud Function script returns object ([#2516](#2516)) ([5de08f8](5de08f8)) * Dashboard scrolls when selecting row in data browser ([#2559](#2559)) ([2aa54a5](2aa54a5)) * Data browser redirects to wrong class when changing app ([#2526](#2526)) ([7713f54](7713f54)) * Deleting all code in the JS Console editor fills in the default code ([#2558](#2558)) ([4b830ba](4b830ba)) * Open pointer in new tab in data browser not working when mount path is not root ([#2527](#2527)) ([2f4081f](2f4081f)) ### Features * Add descriptive statistics for number cells in data browser ([#2529](#2529)) ([ead9ec4](ead9ec4)) * Add filter `starts with` in data browser for fields of type Pointer ([#2553](#2553)) ([0b94ab6](0b94ab6)) * Add Node 20 support; remove Node 14, 16 support ([#2532](#2532)) ([578a339](578a339)) * Add Node 20 support; remove Node 14, 16 support ([#2535](#2535)) ([5c90f2d](5c90f2d)) * Execute script for selected rows ([#2508](#2508)) ([5d9901e](5d9901e)) * Select rows in data browser by clicking and dragging mouse cursor over checkboxes ([#2548](#2548)) ([792ba9e](792ba9e)) ### BREAKING CHANGES * Removes support for Node 14 and 16 ([5c90f2d](5c90f2d))
|
🎉 This change has been released in version 6.0.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Oct 7, 2024
# [6.0.0](5.4.0...6.0.0) (2024-10-07) ### Bug Fixes * App metrics for user and installation counts show dash ([#2528](#2528)) ([850d7b3](850d7b3)) * Class Level Permissions dialog throws error `TypeError: ce.current is null` for newly created class ([#2549](#2549)) ([27ed692](27ed692)) * Config page fails to load ([#2531](#2531)) ([d721b7c](d721b7c)) * Crash after setting filter using context menu and opening filters panel ([#2579](#2579)) ([5a690eb](5a690eb)) * Dashboard crashes if Parse Server Cloud Function script returns object ([#2516](#2516)) ([5de08f8](5de08f8)) * Dashboard not building for Docker platform arm64/v8 ([#2534](#2534)) ([8c4a862](8c4a862)) * Dashboard scrolls when selecting row in data browser ([#2559](#2559)) ([2aa54a5](2aa54a5)) * Data browser redirects to wrong class when changing app ([#2526](#2526)) ([7713f54](7713f54)) * Deleting all code in the JS Console editor fills in the default code ([#2558](#2558)) ([4b830ba](4b830ba)) * Descriptive statistics for number cells in data browser not showing ([#2581](#2581)) ([e146b6f](e146b6f)) * Filter string is erased when changing filter condition ([#2586](#2586)) ([6fa2c8c](6fa2c8c)) * Internal classes `_User`, `_Role`, `_Installation` referenced with pointer don't appear in data browser filter dialog ([#2599](#2599)) ([8239cc8](8239cc8)) * Open pointer in new tab in data browser not working when mount path is not root ([#2527](#2527)) ([2f4081f](2f4081f)) ### Features * Add Cloud Config change history to roll back to previous values ([#2554](#2554)) ([a784129](a784129)) * Add data panel to display object related data fetched via Cloud Function ([#2584](#2584)) ([914cc71](914cc71)) * Add descriptive statistics for number cells in data browser ([#2529](#2529)) ([ead9ec4](ead9ec4)) * Add filter `starts with` in data browser for fields of type Pointer ([#2553](#2553)) ([0b94ab6](0b94ab6)) * Add Node 20 support; remove Node 14, 16 support ([#2532](#2532)) ([578a339](578a339)) * Add Node 20 support; remove Node 14, 16 support ([#2535](#2535)) ([5c90f2d](5c90f2d)) * Add optional restriction of script execution to certain object fields and values ([#2488](#2488)) ([8feac9b](8feac9b)) * Add relational filter conditions in data browser ([#2576](#2576)) ([aa5c68d](aa5c68d)) * Add support for Node 22 ([#2603](#2603)) ([3689106](3689106)) * Execute script for selected rows ([#2508](#2508)) ([5d9901e](5d9901e)) * Select rows in data browser by clicking and dragging mouse cursor over checkboxes ([#2548](#2548)) ([792ba9e](792ba9e)) ### BREAKING CHANGES * Removes support for Node 14 and 16 ([5c90f2d](5c90f2d))
|
🎉 This change has been released in version 6.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Closes: #2502
Approach
The positioning of the update stats code was incorrect, so I restructured the code to ensure that the stats are updated before the function returns.