feat: Add element for subset of data to info panel #2622

vardhan0604 · 2024-10-23T21:58:16Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Closes: #2610

Approach

TODOs before merging

parse-github-assistant · 2024-10-23T21:58:19Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

vardhan0604 · 2024-10-23T22:04:26Z

Screen.Recording.2024-10-24.033012.mp4

Hey @mtrezza, I have added a subset element that allows loading another Cloud Code function on demand. I’m not sure about the styles; could you please let me know what changes and features are required after reviewing the current progress?

uffizzi-cloud · 2024-10-23T22:05:37Z

Uffizzi Ephemeral Environment `deployment-57571`

⌚ Updated Oct 23, 2024, 22:03 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2622

📄 View Application Logs etc.

What is Uffizzi? Learn more

mtrezza · 2024-10-23T22:41:05Z

That is amazing! Just what I had in mind. From a first look I things all that's needed is to refine the design of the section. Let me come up with a mock up... Nice work! Maybe @404-html wants to give this a quick review as well.

404-html · 2024-10-24T08:38:04Z

Hi again Gents! 👋

Maybe @404-html wants to give this a quick review as well.

With pleasure!

src/components/AggregationPanel/AggregationPanelComponents.js

404-html · 2024-10-24T08:52:33Z

src/components/AggregationPanel/AggregationPanelComponents.js

@@ -95,3 +97,116 @@ export const ButtonElement = ({ item, showNote }) => {
    </div>
  );
 };
+
+export const PanelElement = ({ item, showNote, objectId, depth = 0 }) => {


Instead of introducing another PanelElement I would suggest to extend existing one (in AggregationPanel.js), and adopt it to loading data subset and being used recessively. This way we should avoid code duplication.

I have tried doing in the latest commits, can you please review it?

vardhan0604 · 2024-10-24T11:11:34Z

Hi @404-html, I have updated the code as requested. Could you please review it?

404-html · 2024-10-25T07:06:12Z

Hi @404-html, I have updated the code as requested. Could you please review it?

Let me wait for Manuel's UI suggestions, and after they will be addressed I will do another review.

mtrezza · 2024-10-25T19:55:30Z

Not sure why, but for some reason I cannot get the "Show panel" button to show, despite running the same setup like in the previous PR where it worked. @vardhan0604 could you try to rebuild it with the latest commit here and see whether it still works for you?

vardhan0604 · 2024-10-26T15:17:24Z

Not sure why, but for some reason I cannot get the "Show panel" button to show, despite running the same setup like in the previous PR where it worked. @vardhan0604 could you try to rebuild it with the latest commit here and see whether it still works for you?

Yeah, it is working for me. I rebuilt it with the latest commit, and the 'Show panel' button appears as expected. @mtrezza, could you check if parse-dashboard-config.json is configured properly?

mtrezza · 2024-10-29T23:14:30Z

Still trying to get this to work. Meanwhile I found this:

parse-dashboard/src/components/Toolbar/Toolbar.react.js

Line 18 in 6c4d392

const Stats = ({ data, classwiseCloudFunctions, className }) => {

Only remotely related to this PR, but maybe we can clean it up at once. Why was classwiseCloudFunctions added to Stats? If I understand it correctly, classwiseCloudFunctions is just for the info panel, but Stats is a completely different feature?

mtrezza · 2024-10-29T23:34:52Z

#2623 is the reason why the "Show Panel" button isn't showing. Could you take a look?

mtrezza · 2024-10-30T14:00:42Z

src/dashboard/Data/Browser/DataBrowser.react.js

@@ -591,7 +591,7 @@ export default class DataBrowser extends React.Component {
            <ResizableBox
              width={this.state.panelWidth}
              height={Infinity}
-              minConstraints={[100, Infinity]}
+              minConstraints={[400, Infinity]}


Please revert if not required for this PR; the panel should be resizable to min. 100 px width.

mtrezza · 2024-10-30T14:00:54Z

src/dashboard/Data/Browser/DataBrowser.react.js

-      panelWidth: 300,
+      panelWidth: 400,


Why this change?

Sorry, both of them were unintentional changes, i will revert them back in next commit.

mtrezza · 2024-10-30T15:15:17Z

Here's a suggestion for a slight UI refinement:

Collapsed:

Expanded:

Notes

I've tried to better distinguish the expandable section from a segment header by using a different background color, but defining colors may be a future feature, so maybe it's better to avoid assuming certain color combinations but rather focus on form. Anyway, here's how it would look like in a less-intrusive gray for example:
When expanded, the sub-panel is encompassed by a 1px gray line to the left and bottom, to visualize the information hierarchy in the panel.
As we can see in the expanded state, there are 2 "Purchases" headlines right below each other, 1 from the expandable sub-panel item, 1 from the title of the segment within the sub-panel. In cases where this is not desired, the title "Purchases" of the first segment can be avoided by simply not specifying a segment title. That feature doesn't exist yet as the title field is a mandatory property of a segment, but it will be easy to add in a future PR.
I have used the same design language for expandable sections as we already do in the data browser classes for saved filters:
- Collapsed:
- Expanded:

vardhan0604 · 2024-11-01T21:46:40Z

#2623 is the reason why the "Show Panel" button isn't showing. Could you take a look?

Yeah sure. I will take a look

vardhan0604 · 2024-11-02T19:31:46Z

#2623 is the reason why the "Show Panel" button isn't showing. Could you take a look?

@mtrezza, should I push the changes here or open a new PR? I’ve already fixed it locally and also added the UI changes.

mtrezza · 2024-11-03T10:58:01Z

New PR please. It's a fix unrelated to this new feature.

vardhan0604 · 2024-11-03T21:32:06Z

New PR please. It's a fix unrelated to this new feature.

@mtrezza can you review it, I have opened the PR #2627

Also, I’ve implemented the changes according to the UI provided and pushed the changes in this PR. Could you please review and let me know if any additional adjustments are needed.

added changes

2614563

fix lint

f75b108

404-html reviewed Oct 24, 2024

View reviewed changes

unknown added 2 commits October 24, 2024 16:38

update

d029823

fix lint

f9a39db

mtrezza reviewed Oct 30, 2024

View reviewed changes

added changes

aa72ede

undo panel width size changess

c3950d1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add element for subset of data to info panel #2622

feat: Add element for subset of data to info panel #2622

vardhan0604 commented Oct 23, 2024

parse-github-assistant bot commented Oct 23, 2024

vardhan0604 commented Oct 23, 2024

uffizzi-cloud bot commented Oct 23, 2024

mtrezza commented Oct 23, 2024 •

edited

Loading

404-html commented Oct 24, 2024

404-html Oct 24, 2024

vardhan0604 Oct 24, 2024

vardhan0604 commented Oct 24, 2024

404-html commented Oct 25, 2024 •

edited

Loading

mtrezza commented Oct 25, 2024 •

edited

Loading

vardhan0604 commented Oct 26, 2024 •

edited

Loading

mtrezza commented Oct 29, 2024

mtrezza commented Oct 29, 2024 •

edited

Loading

mtrezza Oct 30, 2024

mtrezza Oct 30, 2024

vardhan0604 Nov 1, 2024

mtrezza commented Oct 30, 2024 •

edited

Loading

vardhan0604 commented Nov 1, 2024

vardhan0604 commented Nov 2, 2024 •

edited

Loading

mtrezza commented Nov 3, 2024 •

edited

Loading

vardhan0604 commented Nov 3, 2024 •

edited

Loading

feat: Add element for subset of data to info panel #2622

Are you sure you want to change the base?

feat: Add element for subset of data to info panel #2622

Conversation

vardhan0604 commented Oct 23, 2024

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

parse-github-assistant bot commented Oct 23, 2024

Thanks for opening this pull request!

vardhan0604 commented Oct 23, 2024

uffizzi-cloud bot commented Oct 23, 2024

Uffizzi Ephemeral Environment deployment-57571

mtrezza commented Oct 23, 2024 • edited Loading

404-html commented Oct 24, 2024

404-html Oct 24, 2024

Choose a reason for hiding this comment

vardhan0604 Oct 24, 2024

Choose a reason for hiding this comment

vardhan0604 commented Oct 24, 2024

404-html commented Oct 25, 2024 • edited Loading

mtrezza commented Oct 25, 2024 • edited Loading

vardhan0604 commented Oct 26, 2024 • edited Loading

mtrezza commented Oct 29, 2024

mtrezza commented Oct 29, 2024 • edited Loading

mtrezza Oct 30, 2024

Choose a reason for hiding this comment

mtrezza Oct 30, 2024

Choose a reason for hiding this comment

vardhan0604 Nov 1, 2024

Choose a reason for hiding this comment

mtrezza commented Oct 30, 2024 • edited Loading

Notes

vardhan0604 commented Nov 1, 2024

vardhan0604 commented Nov 2, 2024 • edited Loading

mtrezza commented Nov 3, 2024 • edited Loading

vardhan0604 commented Nov 3, 2024 • edited Loading

Uffizzi Ephemeral Environment `deployment-57571`

mtrezza commented Oct 23, 2024 •

edited

Loading

404-html commented Oct 25, 2024 •

edited

Loading

mtrezza commented Oct 25, 2024 •

edited

Loading

vardhan0604 commented Oct 26, 2024 •

edited

Loading

mtrezza commented Oct 29, 2024 •

edited

Loading

mtrezza commented Oct 30, 2024 •

edited

Loading

vardhan0604 commented Nov 2, 2024 •

edited

Loading

mtrezza commented Nov 3, 2024 •

edited

Loading

vardhan0604 commented Nov 3, 2024 •

edited

Loading