-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applying filters not working #1991
Comments
Thanks for opening this issue!
|
I was able to reproduce this issue in 4.0.0-beta.1 and 4.0.0-alpha.5. |
This looks like a general problem with reading query string params as opening parse dashboard URL that contains filtering have no effect. |
You could go back to see which PR introduced the issue. I suspect that is was a "refactor" PR that just made a minor dependency upgrade, but somehow is causing issues. Unfortunately we do not have UI tests in dashboard to detect these issues before merging, and this is not the first time something like this happens. A few UI tests would be a big help in that regard. |
Git bisect pointed following commit: 1ff1057 |
Hey @mtrezza, in my previous comment I pointed exact commit which introduced the issue. |
@visualfanatic since you have more insight into #1948, could you take a quick look at this issue here? it may be related to the React context API change, there are also a few similar new issues where an action in the UI has no effect, so I would assume it may be a |
@mtrezza There were some regressions caused by two of my recent refactors and I created a PR with fixes for the issues you mentioned. |
Thanks @visualfanatic for the quick fix! I can confirm it fixes all 3 issues and I already merged the PR, released as |
New Issue Checklist
Issue Description
When filtering the data URL changes but the browser doesn't refresh. It doesn't matter if filters are applied from filters section or context menu.
Steps to reproduce
Actual Outcome
URL changes but nothing happens. Filter panel stays open.
Expected Outcome
Data browser should refresh and show filtered data. I believe in first scenario filters panel should also close.
Environment
Dashboard
4.0.0-beta.1
Chrome
97.0.4692.71
Server
any
Linux
Google Cloud
Database
MongoDB
latest
MongoDB Atlas
Logs
Nothing gets logged in browser' dev tools.
The text was updated successfully, but these errors were encountered: