Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying filters not working #1991

Closed
4 tasks done
404-html opened this issue Jan 12, 2022 · 10 comments · Fixed by #2010
Closed
4 tasks done

Applying filters not working #1991

404-html opened this issue Jan 12, 2022 · 10 comments · Fixed by #2010
Labels
bounty:$50 Bounty applies for fixing this issue (Parse Bounty Program) type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@404-html
Copy link
Member

404-html commented Jan 12, 2022

New Issue Checklist

Issue Description

When filtering the data URL changes but the browser doesn't refresh. It doesn't matter if filters are applied from filters section or context menu.

broken-filters

Steps to reproduce

  1. Go to data browser;
  2. Click on "Filters";
  3. Click on "Apply these filters";

  1. Go to data browser;
  2. Right click on a cell with data;
  3. Click on a "Set filter...";
  4. Pick any option.

Actual Outcome

URL changes but nothing happens. Filter panel stays open.

Expected Outcome

Data browser should refresh and show filtered data. I believe in first scenario filters panel should also close.

Environment

Dashboard

  • Parse Dashboard version: 4.0.0-beta.1
  • Browser (Safari, Chrome, Firefox, Edge, etc.): Chrome
  • Browser version: 97.0.4692.71

Server

  • Parse Server version: any
  • Operating system: Linux
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): Google Cloud

Database

  • System (MongoDB or Postgres): MongoDB
  • Database version: latest
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): MongoDB Atlas

Logs

Nothing gets logged in browser' dev tools.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 12, 2022

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@404-html 404-html added the type:bug Impaired feature or lacking behavior that is likely assumed label Jan 12, 2022
@mtrezza
Copy link
Member

mtrezza commented Jan 12, 2022

I was able to reproduce this issue in 4.0.0-beta.1 and 4.0.0-alpha.5.

@mtrezza mtrezza added the bounty:$50 Bounty applies for fixing this issue (Parse Bounty Program) label Jan 12, 2022
@404-html
Copy link
Member Author

This looks like a general problem with reading query string params as opening parse dashboard URL that contains filtering have no effect.

@mtrezza
Copy link
Member

mtrezza commented Jan 15, 2022

You could go back to see which PR introduced the issue. I suspect that is was a "refactor" PR that just made a minor dependency upgrade, but somehow is causing issues.

Unfortunately we do not have UI tests in dashboard to detect these issues before merging, and this is not the first time something like this happens. A few UI tests would be a big help in that regard.

@404-html
Copy link
Member Author

Git bisect pointed following commit: 1ff1057

@404-html 404-html changed the title Applying filers not working Applying filers not working #easymoney Jan 15, 2022
@mtrezza mtrezza changed the title Applying filers not working #easymoney Applying filers not working Jan 15, 2022
@mtrezza mtrezza pinned this issue Jan 21, 2022
@mtrezza
Copy link
Member

mtrezza commented Jan 21, 2022

@404-html There are a couple of similar looking issues where something in the UI is not working / has no effect:

In case of #2006 it started with version 3.3.0. Could you try to find out the earliest release that introduced the issue, so we can narrow down which commit introduced the issue.

@mtrezza mtrezza mentioned this issue Jan 21, 2022
3 tasks
@404-html
Copy link
Member Author

Hey @mtrezza, in my previous comment I pointed exact commit which introduced the issue.

@mtrezza
Copy link
Member

mtrezza commented Jan 22, 2022

@visualfanatic since you have more insight into #1948, could you take a quick look at this issue here? it may be related to the React context API change, there are also a few similar new issues where an action in the UI has no effect, so I would assume it may be a context issue, which is one of the major changes in #1948.

@damianstasik
Copy link
Contributor

@mtrezza There were some regressions caused by two of my recent refactors and I created a PR with fixes for the issues you mentioned.

@mtrezza mtrezza linked a pull request Jan 23, 2022 that will close this issue
5 tasks
@mtrezza mtrezza changed the title Applying filers not working Applying filters not working Jan 23, 2022
@mtrezza mtrezza unpinned this issue Jan 23, 2022
@mtrezza
Copy link
Member

mtrezza commented Jan 23, 2022

Thanks @visualfanatic for the quick fix! I can confirm it fixes all 3 issues and I already merged the PR, released as 4.0.0-alpha-11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty:$50 Bounty applies for fixing this issue (Parse Bounty Program) type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
3 participants