Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Docs for Parse Server 3.10.0 #688

Merged
merged 43 commits into from
Jan 12, 2020

Conversation

Moumouls
Copy link
Member

@Moumouls Moumouls commented Nov 30, 2019

GraphQL Doc

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! This is what I've got so far...

General notes:

  • Perhaps ease up on the bold formatting
  • Maybe run a spell check - I've highlighted some but I'm sure I've missed others

_includes/graphql/classes.md Outdated Show resolved Hide resolved
_includes/graphql/files.md Outdated Show resolved Hide resolved
_includes/graphql/files.md Outdated Show resolved Hide resolved
_includes/graphql/getting-started.md Outdated Show resolved Hide resolved
_includes/graphql/getting-started.md Outdated Show resolved Hide resolved
_includes/graphql/relay.md Outdated Show resolved Hide resolved
_includes/graphql/relay.md Outdated Show resolved Hide resolved
_includes/graphql/relay.md Outdated Show resolved Hide resolved
_includes/graphql/relay.md Outdated Show resolved Hide resolved
_includes/graphql/users.md Outdated Show resolved Hide resolved
@Moumouls
Copy link
Member Author

Moumouls commented Dec 2, 2019

@TomWFox yes i need support of a native english contributor on this doc. I'm French (Baguette) so it's not the best English you can find right now 😄

Could you help on this ?

With my last commit, i think that we have a good start, but tomorrow is my last Open Source Day of the week, and i want to work on missing features of the GraphQL implementation...

@omairvaiyani @davimacedo

Moumouls and others added 18 commits December 2, 2019 18:53
@Moumouls
Copy link
Member Author

Moumouls commented Dec 2, 2019

@TomWFox thanks for the first review ! 😃

@Moumouls
Copy link
Member Author

Moumouls commented Dec 7, 2019

@TomWFox it's strange, i sent batch commit but still conserve Changes requested state...

@Moumouls Moumouls requested a review from TomWFox December 7, 2019 16:27
@davimacedo
Copy link
Member

@TomWFox Since 3.10 was launched with the breaking changes, it is important to release this update ASAP. Can I merge and we can do any correction/improvement later?

@TomWFox
Copy link
Contributor

TomWFox commented Jan 9, 2020

Ah ok, I didn't realise we were going for a 3.10 release, there are definitely still changes to be made but I think its mainly grammatical stuff so its not the end of the world to merge now

@Moumouls
Copy link
Member Author

Moumouls commented Jan 9, 2020

Please just make a last spell check (due to my french English ☺️) then we can merge !

@TomWFox
Copy link
Contributor

TomWFox commented Jan 9, 2020

I can do that tomorrow.

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked 7 of 17 files so far, here is what I have, I'll get to the rest later.

_includes/graphql/files.md Outdated Show resolved Hide resolved
_includes/graphql/files.md Outdated Show resolved Hide resolved
_includes/graphql/files.md Outdated Show resolved Hide resolved
_includes/graphql/getting-started.md Outdated Show resolved Hide resolved
_includes/graphql/getting-started.md Outdated Show resolved Hide resolved
_includes/graphql/objects.md Outdated Show resolved Hide resolved
_includes/graphql/objects.md Outdated Show resolved Hide resolved
_includes/graphql/optimization.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some more, @Moumouls if its ok with you I think it would be much quicker for me to make commits with changes directly.

_includes/graphql/optimization.md Outdated Show resolved Hide resolved
_includes/graphql/optimization.md Outdated Show resolved Hide resolved
_includes/graphql/optimization.md Outdated Show resolved Hide resolved
_includes/graphql/optimization.md Outdated Show resolved Hide resolved
_includes/graphql/optimization.md Outdated Show resolved Hide resolved
_includes/graphql/optimization.md Outdated Show resolved Hide resolved
_includes/graphql/optimization.md Outdated Show resolved Hide resolved
_includes/graphql/optimization.md Outdated Show resolved Hide resolved
@TomWFox
Copy link
Contributor

TomWFox commented Jan 12, 2020

@Moumouls I've unresolved the earlier review comments from @omairvaiyani that you marked as resolved because I checked the first two and the changes haven't been applied.

Could you apply the suggestions or discuss with Omair if you disagree?

@TomWFox TomWFox self-requested a review January 12, 2020 16:34
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I've applied all the suggestions (or similar) from @omairvaiyani, checked all the files and made any changes I thought were necessary and I've built the site and its looking ok.

So... I think this is good enough to merge!

@TomWFox TomWFox merged commit 3341e7b into parse-community:gh-pages Jan 12, 2020
@TomWFox TomWFox changed the title WIP: GraphQL Docs GraphQL Docs for Parse Server 3.10.0 Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants