Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Bump OCMock to 3.9.4 #1822

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 31, 2024

New Pull Request Checklist

Issue Description

Fixes issue when running test on Xcode 16.1 RC / beta. Previously 3.9.2

xxx/NSObject+OCMAdditions.m:49:14: Incompatible function pointer types returning 'void (id _Nonnull, SEL _Nonnull, ...)' from a function with result type 'IMP' (aka 'id  _Nullable (*)(id _Nonnull, SEL _Nonnull, ...)')

https://github.com/erikdoe/ocmock/releases/tag/v3.9.4

Copy link

parse-github-assistant bot commented Oct 31, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

This reverts commit 5701103.
@dplewis dplewis requested a review from a team October 31, 2024 20:47
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.79%. Comparing base (dd05d41) to head (9ad3d33).
Report is 29 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1822       +/-   ##
===========================================
+ Coverage   64.24%   82.79%   +18.55%     
===========================================
  Files         201      282       +81     
  Lines       23233    30726     +7493     
===========================================
+ Hits        14926    25441    +10515     
+ Misses       8307     5285     -3022     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza merged commit db501b5 into parse-community:master Oct 31, 2024
11 checks passed
@dplewis dplewis deleted the ocmock-3.9.4 branch October 31, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants