Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove support for .NET 6.0, 7.0 #396

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Dec 19, 2024

No description provided.

Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@mtrezza mtrezza added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Dec 19, 2024
@mtrezza
Copy link
Member Author

mtrezza commented Dec 19, 2024

BREAKING CHANGE: Removes support for .NET 6.0, 7.0 as they have reached their end-of-life date.

@mtrezza mtrezza force-pushed the feat/remove-support-for-outdated-net branch from 0764997 to 34db672 Compare December 20, 2024 00:24
@YBTopaz8
Copy link
Member

When this passes. My new Request will to.
I only Target .NET 6 as per your suggestion.
After you merge this, my PR should work.

Alternatively, you can accommodate for the request only as well.
I'll be here if there's anything i should do.

@mtrezza
Copy link
Member Author

mtrezza commented Dec 21, 2024

With this PR we'll target .NET 8 as the new min. version. This is currently on hold until the other PRs are merged, so that anyone still using .NET 6 or 7 can benefit from as many fixes in #402 as possible. If there are parts of the PR that are require min .NET 8, we'll merge them after this PR. That's a good example for why it would be great if you could split #40 into individual PRs.

@YBTopaz8
Copy link
Member

YBTopaz8 commented Dec 21, 2024

Done.
I fundamentally did 3 things

  1. Fixed Tests (log out etc), PR is submitted
  2. Fixed Relations. PR submitted (keep in mind it targets only .NET 6, should i update to only .NET 8?
  3. Added more UT to hopefully increase coverage. Submitted as well !

@mtrezza
Copy link
Member Author

mtrezza commented Dec 21, 2024

That sounds good; as mentioned above, I think we should merge (2) and (3) before this PR if that is easily possible; so you can leave the PR for (2) targeting .NET 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants