Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up the applications list #87

Merged
merged 1 commit into from
Jan 14, 2017
Merged

Tidy up the applications list #87

merged 1 commit into from
Jan 14, 2017

Conversation

josevalim
Copy link
Contributor

Not all applications you depend on were specified and
applications that you require only in dev/test were listed.

I have not verified this is correct but it is a push in the
right direction. Please read this blog post for more information:
http://blog.plataformatec.com.br/2016/07/understanding-deps-and-applications-in-your-mixfile/

This may break the test suite but you can fix it by calling
Application.ensure_all_started(:http_server) in your
test_helper.exs.

Not all applications you depend on were specified and
applications that you require only in dev/test were listed.

I have not verified this is correct but it is a push in the
right direction. Please read this blog post for more information:
http://blog.plataformatec.com.br/2016/07/understanding-deps-and-applications-in-your-mixfile/

This may break the test suite but you can fix it by calling
`Application.ensure_all_started(:http_server)` in your
test_helper.exs.
@coveralls
Copy link

coveralls commented Jan 13, 2017

Coverage Status

Coverage decreased (-15.3%) to 78.422% when pulling a84d3e5 on josevalim:patch-1 into b6237c5 on parroty:master.

@wojtekmach
Copy link
Contributor

Btw, for some extra context, folks ran into issues in Elixir v1.4 with the current application list: https://elixirforum.com/t/mix-test-error-in-elixir-1-4-could-not-find-application-file/3255

@parroty parroty merged commit 6a278d5 into parroty:master Jan 14, 2017
@parroty
Copy link
Owner

parroty commented Jan 14, 2017

Thanks for the fix and explanation, I'll be updating along with the change for test_helper.exs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants