Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove elixir 1.4 deprecations #86

Merged
merged 3 commits into from
Jan 6, 2017

Conversation

clekstro
Copy link
Contributor

@clekstro clekstro commented Jan 5, 2017

Elixir 1.4 deprecates the use of defoverridable with private functions and recommends using Enum.uniq_by/2 instead of Enum.uniq/2.

This was adding a fair bit of noise to my test suite after upgrading, so assuming this is merged it might be good to get a new version released so others don't run into it.

@coveralls
Copy link

coveralls commented Jan 5, 2017

Coverage Status

Coverage remained the same at 93.735% when pulling 9912277 on clekstro:remove-elixir-1.4-deprecations into 2663050 on parroty:master.

@coveralls
Copy link

coveralls commented Jan 5, 2017

Coverage Status

Coverage remained the same at 93.735% when pulling 6c7419c on clekstro:remove-elixir-1.4-deprecations into 2663050 on parroty:master.

@parroty parroty merged commit 28b02d6 into parroty:master Jan 6, 2017
@parroty
Copy link
Owner

parroty commented Jan 6, 2017

Thanks!

@clekstro clekstro deleted the remove-elixir-1.4-deprecations branch January 8, 2017 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants