Ensure blacklist header check is case insensitive. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll be publishing it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at a package that uses ExVCR and noticed that the cassettes were not filtering the headers that were specified in the config. It turns out to be a case sensitivity issue. I think it doesn't show up in the ExVCR specs because the test server, HttpServer, seems to use all lowercase headers.
I also noticed there is not a unit test file for
ExVCR.Filter. I added one, but only added tests for theremove_blacklisted_headersmethod for now.P.S. This is my first Elixir PR, apologies if I'm not following proper conventions yet. 😊 I'll be happy to fix mistakes.