Fix cached status code for ibrowse #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, for the ibrowse adapter, status codes are converted back into char lists when loaded from a json file, but not when they're pulled back out of the cache. If you cache a request and then immediately try to use it (without writing it and reading it from a file) the status code we get back from the ibrowse call will be an integer. This fixes that and transforms all status codes back into char lists when pulled directly from the cache.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before storing a response in the cache,
convert_to_stringis called which, for ibrowse, converts the status code from a char list to an integer. This is usually fine, unless you're making the same api request when recording a single cassette. On the second request, the response is grabbed from the cache and passed to ibrowse to return to the user. But, since the stored response has been converted from it's original tuple of char lists, ibrowse returns a response HTTPotion is not expecting, an integer status_code instead of a char list. This might be better solved by changing the representation of the response in the cache, but this fixed the immediate bug we hit in our tests.