Allow matching requests by headers #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,4 +9,12 @@ defmodule ExVCR.Util do | |||
| def uniq_id do | |||
| :os.timestamp |> Tuple.to_list |> Enum.join("") | |||
| end | |||
|
|
|||
| @doc """ | |||
| Takes a keyword lists and returns then as strings. | |||
|
Thanks for merging! Wish I squashed the commits before submitting 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of apps authenticate via a token in the headers. We ran into an issue where exvcr would not allow us to make a request to the same endpoint as a different user and verify different results. This adds the support to allow matching by headers.
I'm happy to take any feedback. Please let me know if there is anything missing.