Fix configuring cassette_library_dir #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cassette_library_dir/2
, that function isactually being called twice. 1st time because of
ConfigLoader.load_defaults and 2nd time with the custom dir. Thus,
calling
File.mkdir_p
insidecassette_library_dir/2
with a customdir, always created 2 dirs: the default one and the custom one
ExVCR.JSON.save/2
creates a directory when it doesn't exist
File.mkdir_p!
since we don't do explicit error handling