Use Jason Instead of JSX

[ruslandoga]

Continues from #179

• rebase
• minimal changes wrt master

---

👋 @parroty

I wonder what you think about using Jason instead of jsx

[barttenbrinke]

This looks good @ruslandoga , maybe @parroty can merge it ? 👍

[parroty]

Thank you for the PR 🙇 . Do you have any insights around compatibility implications with this change? I am just wondering if there's any corner cases that can break by changing the JSON engine 🤔 .

[ruslandoga]

👋 @parroty

Yes, it very well might break something since jsx and Jason have different defaults. For example, the previous attempt to use Jason was blocked by Jason being more strict and not encoding invalid bytes like jsx #179 (comment)

There might be other differences that weren't uncovered by the tests.

[parroty]

The breakage on certain conditions are concerning part of this change, though I understand the concern mentioned in the previous issue. Describe the procedure (for re-recording?), or something...? 🤔

[ruslandoga]

Also #153 lists some concerns people have about depending on jsx through exjsx

I'll try out this branch (exvcr + jason) tomorrow on https://github.com/plausible/analytics and report back if anything breaks.

[ruslandoga]

In Plausible all VCR tests pass without any re-recording: ruslandoga/plausible#147

$  mix test --include slow

13:54:33.063 [info] Migrations already up

13:54:33.091 [info] Migrations already up
Including tags: [:slow]

.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Finished in 123.2 seconds (16.4s async, 106.7s sync)
9 doctests, 1396 tests, 0 failures

I had to update Finch version since ExVCR mocks request!/2,3 functions which were not present in Finch 0.14.

[barttenbrinke]

Imho even though it might break things downstream, keeping this unsupported dependency would also be a reason for people to drop exvcr.

On Fri, 25 Aug 2023 at 08:00, 'ruslandoga' via Retrosync algemene inbox < ***@***.***> wrote: At least in Plausible, all VCR tests ruslandoga/plausible#147 <ruslandoga/plausible#147> pass without any re-recording. I had to update finch version though, since exvcr mocks request!/2,3 functions which were not present in finch 0.14. — Reply to this email directly, view it on GitHub <#206 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACFZ6M67BEW3JOMIQG3EDXXBEQ7ANCNFSM6AAAAAAZRRZL5A> . You are receiving this because you commented.Message ID: ***@***.***>

-- Met vriendelijke groet, Bart ten Brinke 06-47272430 | Retrosync

[parroty]

Thank you for the feedbacks / comments. I am thinking to merge for v0.15.0 (after releasing other ones as v0.14.x). Please allow some time to test on my other libraries too.