Skip to content

Commit

Permalink
chore: Resolve compile warnings -> Adjust Config to not warn in later…
Browse files Browse the repository at this point in the history
… Elixir versions, add missing callbacks that were warning, add oauther to list of applications (#156)
  • Loading branch information
pdgonzalez872 authored Oct 27, 2022
1 parent c355bf7 commit 35f8301
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/test_and_lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ jobs:
strategy:
matrix:
include:
- otp: '20.3'
elixir: '1.5'
- otp: '20.3'
elixir: '1.9'
- otp: '24.2'
Expand Down
2 changes: 1 addition & 1 deletion config/config.exs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use Mix.Config
import Config

config :extwitter, :oauth, [
consumer_key: System.get_env("TWITTER_CONSUMER_KEY"),
Expand Down
3 changes: 3 additions & 0 deletions lib/extwitter/behaviour.ex
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@ defmodule ExTwitter.Behaviour do
A definition of the intended behavior of the core functions.
"""

@callback add_list_members(integer(), list()) :: [ExTwitter.Model.List.t()]
@callback configure(Keyword.t()) :: :ok
@callback configure(:global | :process, Keyword.t()) :: :ok
@callback configure() :: Keyword.t() | nil
@callback create_list(Keyword.t()) :: ExTwitter.Model.List.t()
@callback destroy_list(Keyword.t()) :: ExTwitter.Model.List.t()
@callback request(:get | :post, String.t()) :: map()
@callback request(:get | :post, String.t(), Keyword.t()) :: map()
@callback mentions_timeline :: [ExTwitter.Model.Tweet.t()]
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ defmodule ExTwitter.Mixfile do
def application do
[
mod: {ExTwitter, []},
applications: [:inets, :ssl, :crypto, :logger]
applications: [:inets, :ssl, :crypto, :logger, :oauther]
]
end

Expand Down

0 comments on commit 35f8301

Please sign in to comment.