Skip to content

refactor: suggestions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parmesant merged 7 commits into from
Jan 15, 2025
Merged

refactor: suggestions #2

parmesant merged 7 commits into from
Jan 15, 2025

Conversation

@de-sh
Copy link

@de-sh de-sh commented Jan 15, 2025

Fixes #XXXX.

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh mentioned this pull request Jan 15, 2025
Merged
@parmesant parmesant merged commit 7d9175b into parmesant:date-bin-fix Jan 15, 2025
3 of 4 checks passed
@de-sh de-sh deleted the date-bin-fix branch January 15, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@de-sh @parmesant