Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix init queryInstance concurrent race #32

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Fix init queryInstance concurrent race #32

merged 1 commit into from
Nov 4, 2021

Conversation

bastengao
Copy link
Contributor

Fix #28 , use sync.Once instead of bool flag to avoid concurrent race.

@pariz pariz merged commit d61903d into pariz:master Nov 4, 2021
@bastengao bastengao deleted the fix-init-concurrent-race branch November 5, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling New() concurrently creates data race because of concurrent access to queryInstance global variable
2 participants
@bastengao @pariz