Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FindCountryByNativeName to take advantage of the available info #26

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Add FindCountryByNativeName to take advantage of the available info #26

merged 2 commits into from
Apr 30, 2020

Conversation

pnfb
Copy link
Contributor

@pnfb pnfb commented Sep 13, 2019

  • Adding new map with pre processed native names to country alpha2 for quick lookup

  • Followed pattern used for other tests to cover additions/changes

  • Modified SX (Sint Maarten) data, as the Dutch section does not have FR as an
    official language, this is to prevent collision of native names when building
    the map (see MF, which contains the french native name)

More info: https://en.wikipedia.org/wiki/Sint_Maarten#Languages

* Adding new map with pre processed native names to country alpha2 for quick lookup

* Followed pattern used for other tests to cover additions/changes

* Modified SX (Sint Maarten) data, as the Dutch section does not have FR as an
official language, this is to prevent collision of native names when building
the map (see MF, which contains the french native name)

More info: https://en.wikipedia.org/wiki/Sint_Maarten#Languages
@pnfb
Copy link
Contributor Author

pnfb commented Apr 30, 2020

@pariz Updated to latest in case you are interested in merging these changes.

Cheers!

@pariz
Copy link
Owner

pariz commented Apr 30, 2020

Awesome, thank you!

@pariz pariz merged commit 1c6a393 into pariz:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants