Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FindSubdivision(ByName|ByCode) #21

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Add FindSubdivision(ByName|ByCode) #21

merged 2 commits into from
Oct 29, 2019

Conversation

tylerstillwater
Copy link
Contributor

@tylerstillwater tylerstillwater commented Jun 29, 2018

This change does two things:

  1. Optimizes the loading and storage of subdivisions so that they are owned by their respective countries.
    1. This prevents having to create a new instance of the package with each call to Subdivisions(), which incurred significant overhead.
  2. Adds FindSubdivisionByName and FindSubdivisionByCode. This brings subdivisions on countries in line with the functionality offered by FindCountryByName and FindCountryByAlpha.

@pariz pariz merged commit 233bc78 into pariz:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants