better explanation of the reasoning behind inconsistent pointer/no po…

…inter receiver in the Country struct methods. Also some memory improvements in subdivision struct
pariz · Jul 30, 2017 · a6cd508 · a6cd508
1 parent b4ebec2
commit a6cd508
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/country.go b/country.go
@@ -32,6 +32,8 @@ type Country struct {
 }
 
 // MeasurableCoordinates provides long/lat for country struct
+// it does not store a pointer receiver to Country, as it needs to implement the
+// Measurer interface
 func (c Country) MeasurableCoordinates() (lat, long float64) {
 
 	return c.Coordinates.Latitude, c.Coordinates.Longitude

diff --git a/subdivision.go b/subdivision.go
@@ -12,7 +12,7 @@ type SubDivision struct {
 }
 
 // MeasurableCoordinates provides long/lat for country struct
-func (sd SubDivision) MeasurableCoordinates() (lat, long float64) {
+func (sd *SubDivision) MeasurableCoordinates() (lat, long float64) {
 
 	return sd.Coordinates.Latitude, sd.Coordinates.Longitude