This repository has been archived by the owner on Feb 13, 2023. It is now read-only.
chore: get rid of Name and refactor
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
Nametype, which was previously used to hide exorbitantly-long signatures with a pretty, effect-specific name. Since we now flatten all signatures into a singleEffecttype, this is no longer necessary.Some other minor changes:
coredir toeffects(we can reorganize further as we create more)asmethod attached toEffectfor producing same effect with narrowedTaccessmethod attached toEffectfor producing new effect to resolve specified index of result