Get a config from toml and create a network #100

wirednkod · 2023-09-05T16:17:54Z

Fixes #97

crates/configuration/src/network.rs

crates/configuration/src/relaychain.rs

crates/configuration/src/network.rs

…ontext and add getters/setters; Adjust rest of code for the previous changes

crates/configuration/src/shared/types.rs

crates/configuration/src/shared/constants.rs

github-actions · 2023-09-15T17:01:36Z

Coverage after merging nik-toml-to-network into main

88.48%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
crates/configuration/src
global_settings.rs	96.51%	100%	86.21%	98%	47
hrmp_channel.rs	93.94%	100%	85%	96.20%	45
network.rs	99.21%	100%	97.06%	99.42%	123, 128, 137, 251, 79
parachain.rs	99.17%	100%	95.96%	99.54%	174
relaychain.rs	98.66%	100%	93.94%	99.25%	95
utils.rs	100%	100%	100%	100%
crates/configuration/src/shared
errors.rs	50%	100%	50%	50%
helpers.rs	100%	100%	100%	100%
node.rs	98.08%	100%	91.57%	98.80%	121, 127, 251
resources.rs	95.96%	100%	94.37%	96.31%	102, 114, 126–128, 147–150
types.rs	90.74%	100%	84.16%	92.75%	279–281, 350–352, 367, 371, 60–62
crates/orchestrator/src
lib.rs	100%	100%	100%	100%
crates/provider/src
errors.rs	25%	100%	33.33%	20%	6–8
lib.rs	0%	100%	0%	0%	60–72, 74–85, 88–90
native.rs	46.71%	100%	48.10%	46.54%	100–103, 105, 108–109, 111–114, 129, 137, 163–180, 183–191, 193–202, 204–209, 212–258, 260–264, 266, 268–276, 278–279, 281, 283, 290–295, 297–299, 30, 300–302, 304–308, 311–321, 324, 334–335, 337–341, 344–349, 363, 367, 372–378, 385, 402, 410–411, 427, 429–434, 437–468, 471, 473–479, 481–491, 498, 511, 530, 552, 555–560, 564–567, 570–573, 575–584, 586–590, 592, 596–601, 603–610, 612–625, 627–628, 630–632, 635–641, 643–644, 795, 90, 95–99
crates/provider/src/shared
types.rs	9.36%	100%	10%	8.79%	116, 123–128, 133, 141, 148, 178, 20, 30, 37, 52–58, 66, 72, 78
crates/support/src
net.rs	0%	100%	0%	0%	10, 4–9
crates/support/src/fs
errors.rs	0%	100%	0%	0%	3
local_file.rs	36.36%	100%	33.33%	37.50%	23–25, 27–29, 33–35, 7
mock.rs	44.83%	100%	45.83%	44.63%	109, 124, 136–145, 147–156, 158–172, 52–57, 61–66, 70–75, 79–84
crates/test-runner/src
lib.rs	100%	100%	100%	100%

github-actions · 2023-09-18T09:44:06Z

Coverage after merging nik-toml-to-network into main

88.45%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
crates/configuration/src
global_settings.rs	96.51%	100%	86.21%	98%	47
hrmp_channel.rs	93.94%	100%	85%	96.20%	45
network.rs	99.21%	100%	97.06%	99.42%	123, 128, 137, 251, 79
parachain.rs	99.17%	100%	95.96%	99.54%	174
relaychain.rs	98.66%	100%	93.94%	99.25%	95
utils.rs	100%	100%	100%	100%
crates/configuration/src/shared
errors.rs	50%	100%	50%	50%
helpers.rs	100%	100%	100%	100%
node.rs	98.08%	100%	91.57%	98.80%	121, 127, 251
resources.rs	95.96%	100%	94.37%	96.31%	102, 114, 126–128, 147–150
types.rs	90.29%	100%	84.16%	92.11%	279–281, 350–352, 375–376, 378–380, 60–62
crates/orchestrator/src
lib.rs	100%	100%	100%	100%
crates/provider/src
errors.rs	25%	100%	33.33%	20%	6–8
lib.rs	0%	100%	0%	0%	60–72, 74–85, 88–90
native.rs	46.71%	100%	48.10%	46.54%	100–103, 105, 108–109, 111–114, 129, 137, 163–180, 183–191, 193–202, 204–209, 212–258, 260–264, 266, 268–276, 278–279, 281, 283, 290–295, 297–299, 30, 300–302, 304–308, 311–321, 324, 334–335, 337–341, 344–349, 363, 367, 372–378, 385, 402, 410–411, 427, 429–434, 437–468, 471, 473–479, 481–491, 498, 511, 530, 552, 555–560, 564–567, 570–573, 575–584, 586–590, 592, 596–601, 603–610, 612–625, 627–628, 630–632, 635–641, 643–644, 795, 90, 95–99
crates/provider/src/shared
types.rs	9.36%	100%	10%	8.79%	116, 123–128, 133, 141, 148, 178, 20, 30, 37, 52–58, 66, 72, 78
crates/support/src
net.rs	0%	100%	0%	0%	10, 4–9
crates/support/src/fs
errors.rs	0%	100%	0%	0%	3
local_file.rs	36.36%	100%	33.33%	37.50%	23–25, 27–29, 33–35, 7
mock.rs	44.83%	100%	45.83%	44.63%	109, 124, 136–145, 147–156, 158–172, 52–57, 61–66, 70–75, 79–84
crates/test-runner/src
lib.rs	100%	100%	100%	100%

crates/configuration/src/shared/constants.rs

crates/configuration/src/shared/resources.rs

crates/configuration/src/network.rs

pepoviola

Looks good @wirednkod!!! Couple of comments and nits

github-actions · 2023-09-18T18:53:16Z

Coverage after merging nik-toml-to-network into main

88.44%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
crates/configuration/src
global_settings.rs	96.51%	100%	86.21%	98%	47
hrmp_channel.rs	93.94%	100%	85%	96.20%	45
network.rs	99.20%	100%	97.06%	99.42%	111, 116, 124, 244, 80
parachain.rs	99.17%	100%	95.96%	99.54%	174
relaychain.rs	98.66%	100%	93.94%	99.25%	95
utils.rs	100%	100%	100%	100%
crates/configuration/src/shared
errors.rs	50%	100%	50%	50%
helpers.rs	100%	100%	100%	100%
node.rs	98.08%	100%	91.57%	98.80%	121, 127, 251
resources.rs	95.96%	100%	94.37%	96.31%	102, 114, 126–128, 147–150
types.rs	90.29%	100%	84.16%	92.11%	279–281, 350–352, 375–376, 378–380, 60–62
crates/orchestrator/src
lib.rs	100%	100%	100%	100%
crates/provider/src
errors.rs	25%	100%	33.33%	20%	6–8
lib.rs	0%	100%	0%	0%	60–72, 74–85, 88–90
native.rs	46.71%	100%	48.10%	46.54%	100–103, 105, 108–109, 111–114, 129, 137, 163–180, 183–191, 193–202, 204–209, 212–258, 260–264, 266, 268–276, 278–279, 281, 283, 290–295, 297–299, 30, 300–302, 304–308, 311–321, 324, 334–335, 337–341, 344–349, 363, 367, 372–378, 385, 402, 410–411, 427, 429–434, 437–468, 471, 473–479, 481–491, 498, 511, 530, 552, 555–560, 564–567, 570–573, 575–584, 586–590, 592, 596–601, 603–610, 612–625, 627–628, 630–632, 635–641, 643–644, 795, 90, 95–99
crates/provider/src/shared
types.rs	9.36%	100%	10%	8.79%	116, 123–128, 133, 141, 148, 178, 20, 30, 37, 52–58, 66, 72, 78
crates/support/src
net.rs	0%	100%	0%	0%	10, 4–9
crates/support/src/fs
errors.rs	0%	100%	0%	0%	3
local_file.rs	36.36%	100%	33.33%	37.50%	23–25, 27–29, 33–35, 7
mock.rs	44.83%	100%	45.83%	44.63%	109, 124, 136–145, 147–156, 158–172, 52–57, 61–66, 70–75, 79–84
crates/test-runner/src
lib.rs	100%	100%	100%	100%

github-actions · 2023-09-20T11:38:26Z

Coverage after merging nik-toml-to-network into main

88.47%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
crates/configuration/src
global_settings.rs	96.51%	100%	86.21%	98%	47
hrmp_channel.rs	93.94%	100%	85%	96.20%	45
network.rs	99.21%	100%	97.06%	99.42%	111, 116, 124, 244, 80
parachain.rs	98.43%	100%	95.15%	98.80%	228, 51–53, 67–70
relaychain.rs	98.66%	100%	93.94%	99.25%	95
utils.rs	100%	100%	100%	100%
crates/configuration/src/shared
errors.rs	50%	100%	50%	50%
helpers.rs	100%	100%	100%	100%
node.rs	98.08%	100%	91.57%	98.80%	121, 127, 251
resources.rs	96.09%	100%	94.52%	96.43%	102, 114, 126–128, 147–150
types.rs	90.29%	100%	84.16%	92.11%	279–281, 350–352, 375–376, 378–380, 60–62
crates/orchestrator/src
lib.rs	100%	100%	100%	100%
crates/provider/src
errors.rs	25%	100%	33.33%	20%	6–8
lib.rs	0%	100%	0%	0%	60–72, 74–85, 88–90
native.rs	46.71%	100%	48.10%	46.54%	100–103, 105, 108–109, 111–114, 129, 137, 163–180, 183–191, 193–202, 204–209, 212–258, 260–264, 266, 268–276, 278–279, 281, 283, 290–295, 297–299, 30, 300–302, 304–308, 311–321, 324, 334–335, 337–341, 344–349, 363, 367, 372–378, 385, 402, 410–411, 427, 429–434, 437–468, 471, 473–479, 481–491, 498, 511, 530, 552, 555–560, 564–567, 570–573, 575–584, 586–590, 592, 596–601, 603–610, 612–625, 627–628, 630–632, 635–641, 643–644, 795, 90, 95–99
crates/provider/src/shared
types.rs	9.36%	100%	10%	8.79%	116, 123–128, 133, 141, 148, 178, 20, 30, 37, 52–58, 66, 72, 78
crates/support/src
net.rs	0%	100%	0%	0%	10, 4–9
crates/support/src/fs
errors.rs	0%	100%	0%	0%	3
local_file.rs	36.36%	100%	33.33%	37.50%	23–25, 27–29, 33–35, 7
mock.rs	44.83%	100%	45.83%	44.63%	109, 124, 136–145, 147–156, 158–172, 52–57, 61–66, 70–75, 79–84
crates/test-runner/src
lib.rs	100%	100%	100%	100%

github-actions · 2023-09-21T13:15:28Z

Coverage after merging nik-toml-to-network into main

88.58%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
crates/configuration/src
global_settings.rs	97.36%	100%	89.29%	98.49%
hrmp_channel.rs	95.88%	100%	89.47%	97.44%
network.rs	99.34%	100%	97.78%	99.49%	111, 116, 124, 80
parachain.rs	98.63%	100%	96.08%	98.91%	51–53, 67–70
relaychain.rs	98.99%	100%	95.38%	99.44%
utils.rs	100%	100%	100%	100%
crates/configuration/src/shared
errors.rs	50%	100%	50%	50%
helpers.rs	100%	100%	100%	100%
node.rs	98.32%	100%	92.68%	98.93%	121, 127
resources.rs	96.09%	100%	94.52%	96.43%	102, 114, 126–128, 147–150
types.rs	90.29%	100%	84.16%	92.11%	279–281, 350–352, 375–376, 378–380, 60–62
crates/orchestrator/src
lib.rs	100%	100%	100%	100%
crates/provider/src
errors.rs	25%	100%	33.33%	20%	6–8
lib.rs	0%	100%	0%	0%	60–72, 74–85, 88–90
native.rs	46.71%	100%	48.10%	46.54%	100–103, 105, 108–109, 111–114, 129, 137, 163–180, 183–191, 193–202, 204–209, 212–258, 260–264, 266, 268–276, 278–279, 281, 283, 290–295, 297–299, 30, 300–302, 304–308, 311–321, 324, 334–335, 337–341, 344–349, 363, 367, 372–378, 385, 402, 410–411, 427, 429–434, 437–468, 471, 473–479, 481–491, 498, 511, 530, 552, 555–560, 564–567, 570–573, 575–584, 586–590, 592, 596–601, 603–610, 612–625, 627–628, 630–632, 635–641, 643–644, 795, 90, 95–99
crates/provider/src/shared
types.rs	9.36%	100%	10%	8.79%	116, 123–128, 133, 141, 148, 178, 20, 30, 37, 52–58, 66, 72, 78
crates/support/src
net.rs	0%	100%	0%	0%	10, 4–9
crates/support/src/fs
errors.rs	0%	100%	0%	0%	3
local_file.rs	40%	100%	40%	40%	22–24, 26–28, 32–34
mock.rs	44.83%	100%	45.83%	44.63%	109, 124, 136–145, 147–156, 158–172, 52–57, 61–66, 70–75, 79–84
crates/test-runner/src
lib.rs	100%	100%	100%	100%

init

de20044

wirednkod marked this pull request as draft September 5, 2023 16:18

wirednkod added 4 commits September 5, 2023 20:16

Add test

43d1ba4

fmt

21047b0

latest changes

9d1bd12

Update Decentralize for U128

95640ae

l0r1s suggested changes Sep 9, 2023

View reviewed changes

crates/configuration/src/network.rs Outdated Show resolved Hide resolved

pepoviola reviewed Sep 9, 2023

View reviewed changes

crates/configuration/src/network.rs Outdated Show resolved Hide resolved

pepoviola reviewed Sep 9, 2023

View reviewed changes

crates/configuration/src/network.rs Outdated Show resolved Hide resolved

pepoviola reviewed Sep 9, 2023

View reviewed changes

crates/configuration/src/relaychain.rs Outdated Show resolved Hide resolved

pepoviola reviewed Sep 9, 2023

View reviewed changes

crates/configuration/src/relaychain.rs Outdated Show resolved Hide resolved

pepoviola reviewed Sep 9, 2023

View reviewed changes

crates/configuration/src/network.rs Outdated Show resolved Hide resolved

wirednkod and others added 9 commits September 11, 2023 11:22

Move to NetworkConfig and rename to load_from_toml

8a27c69

Introduce constants for expect

4ad98ef

Alter logic

edc68a9

Alter logic

8faed6d

Minor fixes

0344f1e

Changes to include setters

c17e270

change loop logic

56deb74

Remove chain_context from loops; Remove pub(crate) from ChainDefaultC…

27aff5d

…ontext and add getters/setters; Adjust rest of code for the previous changes

fmt

769b73a

pepoviola reviewed Sep 11, 2023

View reviewed changes

crates/configuration/src/shared/types.rs Show resolved Hide resolved

pepoviola reviewed Sep 11, 2023

View reviewed changes

crates/configuration/src/shared/constants.rs Outdated Show resolved Hide resolved

wirednkod added 7 commits September 11, 2023 23:10

make private again

712a314

Revert changes on ChainDefaultContext

5e5c902

Remove non-used constant

42a9401

Revert erroneously pushed code

96f7ffd

minor leftover

48ea08b

Fix more on the convertion from toml to network

63f4992

fix Deserialization

902a56b

wirednkod added 2 commits September 18, 2023 12:39

Alter deserialize of args with regex

7254f22

fmt

4cdcb6b

l0r1s reviewed Sep 18, 2023

View reviewed changes

crates/configuration/src/shared/constants.rs Outdated Show resolved Hide resolved

l0r1s reviewed Sep 18, 2023

View reviewed changes

crates/configuration/src/shared/resources.rs Show resolved Hide resolved

wirednkod requested a review from l0r1s September 18, 2023 12:14

pepoviola reviewed Sep 18, 2023

View reviewed changes

crates/configuration/src/network.rs Outdated Show resolved Hide resolved

pepoviola reviewed Sep 18, 2023

View reviewed changes

crates/configuration/src/network.rs Outdated Show resolved Hide resolved

pepoviola reviewed Sep 18, 2023

View reviewed changes

crates/configuration/src/network.rs Show resolved Hide resolved

pepoviola reviewed Sep 18, 2023

View reviewed changes

crates/configuration/src/network.rs Outdated Show resolved Hide resolved

pepoviola reviewed Sep 18, 2023

View reviewed changes

crates/configuration/src/network.rs Outdated Show resolved Hide resolved

pepoviola reviewed Sep 18, 2023

View reviewed changes

wirednkod added 2 commits September 18, 2023 20:57

Address comments

8f5f3ee

fmt

5902257

wirednkod requested a review from pepoviola September 18, 2023 18:06

wirednkod added 4 commits September 18, 2023 21:09

clippy fix

0bddfba

clippy again

a91798d

Alter for bypassing clippy

e8011ce

fmt

335ad80

wirednkod added 3 commits September 20, 2023 09:45

Add resources deserializer test

915d4c8

tmp Deserialization

7c8fb06

Finalize tests in Deserializations

74054ef

Merge branch 'main' into nik-toml-to-network

0046708

pepoviola approved these changes Sep 21, 2023

View reviewed changes

wirednkod merged commit fe91d05 into main Sep 21, 2023

wirednkod deleted the nik-toml-to-network branch September 21, 2023 15:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get a config from toml and create a network #100

Get a config from toml and create a network #100

wirednkod commented Sep 5, 2023 •

edited

Loading

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 18, 2023

pepoviola left a comment

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 21, 2023

Get a config from toml and create a network #100

Get a config from toml and create a network #100

Conversation

wirednkod commented Sep 5, 2023 • edited Loading

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 18, 2023

pepoviola left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 21, 2023

wirednkod commented Sep 5, 2023 •

edited

Loading