Skip to content

*: update criterion to v0.4.0#176

Merged
cheme merged 1 commit intoparitytech:masterfrom
koushiro:update-criterion
Jan 13, 2023
Merged

*: update criterion to v0.4.0#176
cheme merged 1 commit intoparitytech:masterfrom
koushiro:update-criterion

Conversation

@koushiro
Copy link
Contributor

@koushiro koushiro commented Dec 18, 2022

@koushiro
Copy link
Contributor Author

@ordian PTAL

trie-root = { path = "../../trie-root", version = "0.17.0" }
trie-db = { path = "../../trie-db", version = "0.24.0" }
criterion = "0.3.3"
criterion = "0.4.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ordian could you release a new version of trie-bench after merging this PR ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koushiro just did publish it, thanks for the PR.

Copy link
Contributor

@mrcnski mrcnski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup and refactor!

@mrcnski mrcnski requested review from cheme and ordian January 13, 2023 18:11
Copy link
Contributor

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cheme cheme merged commit 4902e93 into paritytech:master Jan 13, 2023
@koushiro koushiro deleted the update-criterion branch January 14, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants