rpc: Expose the subscription ID for RpcClientT
#733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
niklasad1
reviewed
Nov 24, 2022
| @@ -62,3 +62,6 @@ pub type RpcFuture<'a, T> = | |||
| /// The inner subscription stream returned from our [`RpcClientT`]'s `subscription` method. | |||
| pub type RpcSubscription = | |||
| Pin<Box<dyn Stream<Item = Result<Box<RawValue>, RpcError>> + Send + 'static>>; | |||
|
|
|||
| /// The ID associated with the [`RpcClientT`]'s `subscription`. | |||
| pub type RpcSubscriptionId = String; | |||
There was a problem hiding this comment.
This is configurable in substrate via the SubscriptionIdProvider so it could something different than String. Should be String 99% of cases anyway but just saying.
Does the new rpc api v2 specify the format of the subscription ID? :)
There was a problem hiding this comment.
The RPC layer should take the subscriptionID as a parameter in string format. From chainHead_unstable_body:
followSubscription: An opaque string that was returned by chainHead_unstable_follow.
niklasad1
approved these changes
Nov 24, 2022
Signed-off-by: Alexandru Vasile <[email protected]>
jsdw
approved these changes
Nov 25, 2022
Xanewok
approved these changes
Nov 25, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extent the
RpcClientTto obtain the ID associated with subscriptions.To ensure that this extension is not impacting users that do not want to
implement/return it, the subscription ID is optional.
The subscription ID needs to be exposed for implementing #732.