Skip to content

Allow passing $OUT_DIR in the runtime_metadata_path attribute #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pgherveou merged 5 commits into from
Dec 9, 2025
Merged

Allow passing $OUT_DIR in the runtime_metadata_path attribute #2142

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2599980
Allow passing $OUT_DIR in the runtime_metadata_path attribute
pgherveou Dec 9, 2025
e2565e3
nit
pgherveou Dec 9, 2025
930afc9
fix build
pgherveou Dec 9, 2025
6ed81d6
PR review
pgherveou Dec 9, 2025
1c20d42
ignore instead of no_run
pgherveou Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions macro/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,18 @@ fn fetch_metadata(args: &RuntimeMetadataArgs) -> Result<subxt_codegen::Metadata,
)
}

let root = std::env::var("CARGO_MANIFEST_DIR").unwrap_or_else(|_| ".".into());
let root_path = std::path::Path::new(&root);
let path = root_path.join(rest_of_path);
// Replace $OUT_DIR with the actual OUT_DIR environment variable
let path = if rest_of_path.contains("$OUT_DIR") {
let out_dir = std::env::var("OUT_DIR").unwrap_or_else(|_| {
abort_call_site!("$OUT_DIR is used in runtime_metadata_path but OUT_DIR environment variable is not set")
});
std::path::Path::new(&rest_of_path.replace("$OUT_DIR", &out_dir)).into()
} else {
let root = std::env::var("CARGO_MANIFEST_DIR").unwrap_or_else(|_| ".".into());
let root_path = std::path::Path::new(&root);
root_path.join(rest_of_path)
};

@jsdw jsdw Dec 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make a little function for this and apply the same logic above for lines 216-218; people would expect to be able to do the same thing for the runtime-wasm-path field


subxt_utils_fetchmetadata::from_file_blocking(&path)
.and_then(|b| subxt_codegen::Metadata::decode(&mut &*b).map_err(Into::into))
.map_err(|e| CodegenError::Other(e.to_string()).into_compile_error())?
Expand Down
Loading