Skip to content

Improve error message regarding failure to extract metadata from WASM runtime #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsdw merged 3 commits into from
Mar 13, 2025
Merged

Improve error message regarding failure to extract metadata from WASM runtime #1961

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ef4949
Improve error message re failure to extract metadata from runtime
jsdw Mar 12, 2025
7566115
Improve error on legacy metadata loading too
jsdw Mar 12, 2025
59c5031
allow missing host funcs, too
jsdw Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions macro/src/wasm_loader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,10 @@ impl Executor {
"Metadata_metadata_at_version",
&version.encode(),
)
.map_err(|_| {
CodegenError::Wasm(
"method \"Metadata_metadata_at_version\" doesnt exist".to_owned(),
)
.map_err(|e| {
CodegenError::Wasm(format!(
"Failed to call \"Metadata_metadata_at_version\" on WASM runtime. Cause: {e}"
))
})?;
let Some(encoded_metadata) =
<Option<Vec<u8>>>::decode(&mut &encoded_metadata[..]).map_err(CodegenError::Decode)?
Expand Down