Skip to content

Fix CLI storage diff #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsdw merged 2 commits into from
Mar 12, 2025
Merged

Fix CLI storage diff #1958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34d1f92
Fix CLI storage diff
jsdw Mar 12, 2025
0c62504
attempt to avoid race in tests
jsdw Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/src/commands/diff.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ impl StorageEntryDiff {
.type_hash(value_1_ty_id)
.expect("type is in metadata; qed");
let value_2_ty_id = storage_entry_2.entry_type().value_ty();
let value_2_hash = metadata_1
let value_2_hash = metadata_2
.type_hash(value_2_ty_id)
.expect("type is in metadata; qed");
let value_different = value_1_hash != value_2_hash;
Expand Down
4 changes: 3 additions & 1 deletion testing/integration-tests/src/full_client/client/archive_rpcs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ use crate::{
utils::{node_runtime, TestNodeProcess},
};
use codec::Encode;
use futures::{Stream, StreamExt};
use futures::{stream, Stream, StreamExt};
use std::task::Poll;
use subxt::{
blocks::Block,
client::OnlineClient,
Expand All @@ -33,6 +34,7 @@ async fn fetch_finalized_blocks<T: Config>(
.subscribe_finalized()
.await
.expect("issue subscribing to finalized in fetch_finalized_blocks")
.skip(1) // <- skip first block incase next is close to being ready already.
.take(n)
.map(|r| r.expect("issue fetching block in fetch_finalized_blocks"))
}
Expand Down
Loading