Skip to content

Remove visibility limiter pub (crate) from Metadata #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascjones merged 3 commits into from
Sep 14, 2020
Merged

Remove visibility limiter pub (crate) from Metadata #162

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ef3fde
Remove visibility limiter `pub (crate)`
enfipy Sep 11, 2020
8c8fc17
Run fmt
enfipy Sep 14, 2020
808181e
Add comments
enfipy Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/metadata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,8 @@ impl Metadata {
.ok_or(MetadataError::ModuleNotFound(name))
}

pub(crate) fn module_with_calls<S>(
&self,
name: S,
) -> Result<&ModuleWithCalls, MetadataError>
/// Returns `ModuleWithCalls`.
pub fn module_with_calls<S>(&self, name: S) -> Result<&ModuleWithCalls, MetadataError>
where
S: ToString,
{
Expand All @@ -106,11 +104,13 @@ impl Metadata {
.ok_or(MetadataError::ModuleNotFound(name))
}

pub(crate) fn modules_with_events(&self) -> impl Iterator<Item = &ModuleWithEvents> {
/// Returns Iterator of `ModuleWithEvents`.
pub fn modules_with_events(&self) -> impl Iterator<Item = &ModuleWithEvents> {
self.modules_with_events.values()
}

pub(crate) fn module_with_events(
/// Returns `ModuleWithEvents`.
pub fn module_with_events(
&self,
module_index: u8,
) -> Result<&ModuleWithEvents, MetadataError> {
Expand All @@ -120,7 +120,8 @@ impl Metadata {
.ok_or(MetadataError::ModuleIndexNotFound(module_index))
}

pub(crate) fn module_with_errors(
/// Returns `ModuleWithErrors`.
pub fn module_with_errors(
&self,
module_index: u8,
) -> Result<&ModuleWithErrors, MetadataError> {
Expand Down