Macro error messages validating metadata and making suggestions #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* lightclient: Close wasm socket while dropping from connecting state Signed-off-by: Alexandru Vasile <[email protected]> * lightclient: Construct one time only closures Signed-off-by: Alexandru Vasile <[email protected]> * testing: Enable console logs for lightclient WASM testing Signed-off-by: Alexandru Vasile <[email protected]> * lightclient: Separate wakes and check connectivity on poll_read Signed-off-by: Alexandru Vasile <[email protected]> * lightclient: Close the socket depending on internal state Signed-off-by: Alexandru Vasile <[email protected]> * Revert "lightclient: Separate wakes and check connectivity on poll_read" This reverts commit 8660940. * lightclient: Return pending if socket is opening from poll_read Signed-off-by: Alexandru Vasile <[email protected]> * lightclient: Close the socket on `poll_close` Signed-off-by: Alexandru Vasile <[email protected]> * lightclient: Reset closures on Drop to avoid recursive invokation Signed-off-by: Alexandru Vasile <[email protected]> * lightclient: Close the socket if not already closing Signed-off-by: Alexandru Vasile <[email protected]> --------- Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
* cli: Add chainSpec command Signed-off-by: Alexandru Vasile <[email protected]> * cli/chainSpec: Move to dedicated module Signed-off-by: Alexandru Vasile <[email protected]> * cli: Compute the state root hash Signed-off-by: Alexandru Vasile <[email protected]> * cli: Remove code substitutes Signed-off-by: Alexandru Vasile <[email protected]> * artifacts: Update polkadot.json Signed-off-by: Alexandru Vasile <[email protected]> * scripts: Generate the chain spec Signed-off-by: Alexandru Vasile <[email protected]> * cli: Remove testing artifacts Signed-off-by: Alexandru Vasile <[email protected]> * cli: Fix clippy Signed-off-by: Alexandru Vasile <[email protected]> * cli: Apply rustfmt Signed-off-by: Alexandru Vasile <[email protected]> * cli: Introduce feature flag for smoldot dependency Signed-off-by: Alexandru Vasile <[email protected]> * cli: Rename chain-spec to chain-spec-pruning Signed-off-by: Alexandru Vasile <[email protected]> * scripts: Update chain-spec command Signed-off-by: Alexandru Vasile <[email protected]> --------- Signed-off-by: Alexandru Vasile <[email protected]>
* update crypto dependencies, adjust keypair * add scale_info::TypeInfo derive in some places * add multi signature derive
…on' into tadeohepperle/macro-better-error-messages
tadeohepperle
changed the title
tadeohepperle
changed the title
niklasad1
reviewed
Jan 19, 2024
macro/src/lib.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// Fetches metadata in a blocking manner, either from a url (not recommended) or from a file path. |
There was a problem hiding this comment.
I don't get why fetching metadata from an URL is not recommended? :)
There was a problem hiding this comment.
It is not recommended for users because the compilation blocks while fetching the metadata, which is a bit slow and (maybe flaky) compared to using metadata file. But yeah, maybe the docs of this function don't need to mention this.
There was a problem hiding this comment.
Maybe we can say its not recommended for production use-cases. Do remember we added the ability to fetch the metadata from URL as a feature request from the cargo-contract team, that wanted to fetch a fresh metadata for their testing
niklasad1
reviewed
Jan 19, 2024
niklasad1
approved these changes
Jan 19, 2024
Co-authored-by: Niklas Adolfsson <[email protected]>
lexnv
reviewed
Jan 22, 2024
macro/src/lib.rs
Outdated
| } | ||
|
|
||
| // Note: just an additional function to make early returns easier. | ||
| fn _subxt(args: TokenStream, item_mod: syn::ItemMod) -> Result<TokenStream, TokenStream> { |
There was a problem hiding this comment.
nit: or subxt_inner; the underscore leads me to wonder if we are going to use the function (similar to let _unused = ..)
lexnv
reviewed
Jan 22, 2024
macro/Cargo.toml
Outdated
| @@ -23,5 +23,7 @@ proc-macro = true | |||
| codec = { package = "parity-scale-codec", workspace = true } | |||
| darling = { workspace = true } | |||
| proc-macro-error = { workspace = true } | |||
| syn = { workspace = true } | |||
| syn.workspace = true | |||
There was a problem hiding this comment.
I do wonder, did this happen as a result of some linting extensions from your IDE?
We could revert this to keep consistency with the dependencies of this file (syn = { workspace = true })
lexnv
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1269
Branched from #1260 so #1260 should be merged first.
This PR introduces checks to all user defined type paths that are passed to the subxt macro. This could be a custom derive, attribute or a substitute for a type. The macro now makes sure that the specified path exists in the type registry. If this is not fulfilled it errors and gives the user a list of valid paths that belong to a Type with the same name. Here is an example: