This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Reduce the number of types in build_transport for transport#9793
Merged
2 commits merged intomasterfrom Sep 16, 2021
Merged
Conversation
kpp
added
A0-please_review
bkchr
approved these changes
Sep 15, 2021
tomaka
approved these changes
Sep 16, 2021
Contributor
|
You probably need to merge master or something because the Polkadot/Substrate compatibility was broken when you opened the PR. |
Contributor
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the resulting type of transport was
OrTransport<OptionalTransport<EitherTransport<A,B>>, OptionalTransport<C>>. Now it isEitherTransport<EitherTransport<A,B>, OptionalTransport<C>>.The semantics is unchanged but the code is simplified a little bit.