Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add PR #9442 for 0.9.10#9767

Merged
gilescope merged 1 commit intopolkadot-v0.9.10from
wk-0.9.10_pr-9442
Sep 13, 2021
Merged

Add PR #9442 for 0.9.10#9767
gilescope merged 1 commit intopolkadot-v0.9.10from
wk-0.9.10_pr-9442

Conversation

@chevdor
Copy link
Contributor

@chevdor chevdor commented Sep 13, 2021 •
edited
Loading

PR #9442 is required for paritytech/polkadot#3628

  • Partially applied
  • Everything builds, need to implement compact encoding as well.
  • Fix some tests, add a ui test as well.
  • Fix everything and everything.
  • small nits
  • a bunch more rename
  • more reorg
  • more reorg
  • last nit of self-review
  • Seemingly fixed the build now
  • Fix build
  • make it work again
  • Update primitives/npos-elections/solution-type/src/lib.rs
    Co-authored-by: Guillaume Thiolliere gui.thiolliere@gmail.com
  • Update primitives/npos-elections/solution-type/src/lib.rs
    Co-authored-by: Guillaume Thiolliere gui.thiolliere@gmail.com
  • nits
  • factor out double type
  • fix try-build
    Co-authored-by: Guillaume Thiolliere gui.thiolliere@gmail.com

@kianenigma @gui1117 @chevdor
Multi-Block Election part 0: preparation and some cleanup. (#9442)
6e74231 
* Partially applied

* Everything builds, need to implement compact encoding as well.

* Fix some tests, add a ui test as well.

* Fix everything and everything.

* small nits

* a bunch more rename

* more reorg

* more reorg

* last nit of self-review

* Seemingly fixed the build now

* Fix build

* make it work again

* Update primitives/npos-elections/solution-type/src/lib.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

* Update primitives/npos-elections/solution-type/src/lib.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

* nits

* factor out double type

* fix try-build

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
@chevdor chevdor added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 13, 2021
@chevdor chevdor marked this pull request as ready for review September 13, 2021 10:22
@chevdor chevdor requested a review from kianenigma as a code owner September 13, 2021 10:22
@chevdor chevdor mentioned this pull request Sep 13, 2021
Merged
@chevdor chevdor added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Sep 13, 2021
gilescope
gilescope approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilescope gilescope merged commit 58f0223 into polkadot-v0.9.10 Sep 13, 2021
@gilescope gilescope deleted the wk-0.9.10_pr-9442 branch September 13, 2021 17:02
@ghzlatarev ghzlatarev mentioned this pull request Sep 23, 2021
Merged
15 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@gilescope gilescope gilescope approved these changes

@kianenigma kianenigma kianenigma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chevdor @gilescope @kianenigma

Comments