This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
- Avoid using clone() for the Copy type `PeerId`. - Use `find_map` for `filter_map` and `next`. - Use `Self`.
bkchr
approved these changes
Sep 13, 2021
bkchr
added
A0-please_review
kpp
reviewed
Sep 13, 2021
client/network/src/service.rs
Outdated
| .map(|_| default_notif_handshake_message.clone()), | ||
| ) | ||
| .collect(), | ||
| vec![default_notif_handshake_message; params.network_config.extra_sets.len()], |
Contributor
There was a problem hiding this comment.
Well, no. elems[0] should be an empty Vec.
Contributor
There was a problem hiding this comment.
Try this:
fn main() {
core::iter::once(Vec::<()>::new()).inspect(|x| {dbg!(&x);}).collect::<Vec<_>>();
}
Contributor
Author
There was a problem hiding this comment.
Reverted. Interesting, didn't realize the code is not equivalent as before, [[]] is not [], https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=ca2a7d77fe4d52b1e0ae709f20cdee83 . Do you mind sharing more about why elems[0] has to be an empty Vec?
kpp
suggested changes
Sep 13, 2021
kpp
approved these changes
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mainly about cleaning up
sc-network. No logical changes, all trivial improvements:clone()for the Copy type likePeerId.find_mapforfilter_mapandnext.Self.matches!if suitable.