This repository was archived by the owner on Nov 15, 2023. It is now read-only.
nix: substrate depends on openssl#9556
Merged
gilescope merged 2 commits intoparitytech:masterfrom Sep 14, 2021
Merged
Conversation
|
Interesting, maybe ring could replace openssl in some dependency. |
bkchr
approved these changes
Aug 13, 2021
Contributor
Author
|
I'd certainly trust rustls given that google's security people are keen on using that inside curl (and it's pure rust rather than a native dependency). ( https://www.abetterinternet.org/post/preparing-rustls-for-wider-adoption/ ) |
Contributor
Author
|
(Hopefully jsonrpsee will be dependent on rustls.) |
gilescope
added
A0-please_review
Contributor
Yes, it is currently at least :) FWIW, I think it's rather easy to change to |
niklasad1
approved these changes
Sep 6, 2021
andresilva
approved these changes
Sep 13, 2021
Contributor
|
bot merge |
|
Merge aborted: Checks failed for 38eecb5 |
Contributor
|
bot merge force |
|
Trying merge. |
|
Merge failed: "2 of 8 required status checks are expected." |
Member
|
@gilescope please merge master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed if I didn't do this I sometimes hit compile errors so we must depend on openssl at the moment.