This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
arkpar
added
A0-please_review
bkchr
approved these changes
Jul 6, 2021
Member
|
bot merge |
|
Trying merge. |
|
Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count |
ghost
approved these changes
Jul 6, 2021
ghost
merged commit 
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes an assertion that pending state can't be pinned. There's a race that allows for such states to be accessed indeed. Since in-memory changes to state-db are applied after the blockchain metadata changes. Pinning such states is a no-op anyway, since all pins are short-lived and by the time metadata changes are applied it is guaranteed that the state won't be reverted.
See paritytech/polkadot#3414 for context.